Adding documentation and actions for docker & CI#41
Conversation
|
Excited for this PR!~!! |
karlfloersch
left a comment
There was a problem hiding this comment.
Looks great!! Left a couple questions/comments but overall exciting to start pushing to a live deployment! Woot woot!
| jobs: | ||
| build: | ||
| name: Build, Tag & push to ECR, Deploy task | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Good to use Linux because it's the cheapest resource!
|
|
||
| - name: Stop existing dev-rollup-full-node ECS task | ||
| run: | | ||
| ./.github/scripts/stop-ecs-task.sh dev-rollup-full-node rollup-full-node |
There was a problem hiding this comment.
I am a little confused why Stop existing dev-rollup-full-node ECS task is after Build, tag, and push image to Amazon ECR as opposed to before. Where is it starting up the new container?
Other than this everything in the config makes a lot of sense!!! Very cool!!
There was a problem hiding this comment.
The rollup-full-node service in the dev-rollup-full-node cluster aims to always have exactly 1 healthy task that is the tagged latest image in ECR. So we push the new image so that it becomes the tagged latest version in ECR and then kill the currently-running task so that a new one with the new image gets auto-started in its place.
There was a problem hiding this comment.
We'll probably need a better approach for higher environments, but this should work for now for dev.
packages/rollup-full-node/README.md
Outdated
| Run `yarn build` to build the code. Note: `yarn all` may be used to build and run tests. | ||
|
|
||
| ## Building Docker Image | ||
| Install [docker]() |
There was a problem hiding this comment.
Should technically be an extra newline between this and the next line otherwise it will all show up on the same line. -- https://github.com/ethereum-optimism/optimism-monorepo/blob/ee10d4186dfc7511f2d1aba2df49dc2f97a6ecca/packages/rollup-full-node/README.md
packages/rollup-full-node/README.md
Outdated
| ### Pushing Image to AWS Registry: | ||
| Make sure the [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-install.html) is installed and [configured](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-configure.html#cli-quick-configuration) | ||
| 1) Make sure you're authenticated: | ||
| ```aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin <aws_account_id>.dkr.ecr.us-east-2.amazonaws.com/optimism/rollup-full-node``` |
There was a problem hiding this comment.
I think here if you make a newline after "```" then it'll show up as a codeblock which might be more readable
readme terminology consistency
* feat: Add `TxDeposit` type * feat: Add OP fields to `Receipt`
commit 5461b46bff4ff4de09a16b37212781317c96ccba
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 23:41:10 2024 +0900
test
commit 1abf791d2999033460d9a51246b8474c00a6fde4
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:39:25 2024 +0900
Reapply "feat: Add a name when registering rollupConfig"
This reverts commit e2dcccb2e6379f22acad0b391d448a30ae79dcc7.
commit 0f5a7a6e31a5d42f99dcdf24714b5baaf372652a
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:38:50 2024 +0900
Revert "feat: Add a name when registering rollupConfig"
This reverts commit c3d5e85537b0de4a24a909e4f5fb1a01805873c2.
commit 4c01ef3f9ce90e0bf3d26cf1de62fc5d2dde1d9c
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:38:09 2024 +0900
test: prevent duplicate names
Adding the name when registering rollupConfig, test to prevent duplicate names
commit 609463b002a97afedc1bec8b6f4f54ee9133c946
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 21:51:36 2024 +0900
fix: test5 ethereum-optimism#41
commit f3870375d05be97c218239a9580df0ba5c526f7b
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:42:32 2024 +0900
Update L1BridgeRegistryV1_1.sol ethereum-optimism#41
commit 0bb3c7705563b5c8e9b88defe80c15c8bcbeec0a
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:39:25 2024 +0900
Reapply "feat: Add a name when registering rollupConfig"
This reverts commit e2dcccb2e6379f22acad0b391d448a30ae79dcc7.
commit 0237b031145e6bb46a8285abbb8698a3b18d34fc
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:38:50 2024 +0900
Revert "feat: Add a name when registering rollupConfig"
This reverts commit c3d5e85537b0de4a24a909e4f5fb1a01805873c2.
commit baf931c7134c45f7bca8bed7181fa2900d931199
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:38:09 2024 +0900
test: prevent duplicate names
Adding the name when registering rollupConfig, test to prevent duplicate names
commit c228611630a91e8ea26d0b1b7664248dd2bfe22a
Author: Zena-park <zena@tokamak.network>
Date: Mon Sep 30 19:36:13 2024 +0900
feat: Add a name when registering rollupConfig
- Add a name when registering rollupConfig
- Modify logic to prevent registration of duplicate names
Description
Contributing Agreement