Skip to content

Support historical code lookups if the block number is current#53

Merged
masonforest merged 7 commits intomasterfrom
YAS-208/Synthetix/HistoricalCodeLookups
Mar 24, 2020
Merged

Support historical code lookups if the block number is current#53
masonforest merged 7 commits intomasterfrom
YAS-208/Synthetix/HistoricalCodeLookups

Conversation

@masonforest
Copy link
Copy Markdown

Description

Support historical code lookups if the block number is current

Metadata

Fixes

Contributing Agreement

Copy link
Copy Markdown

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

`No support for historical code lookups! Anything returned from this may be very wrong.`
)
//throw new Error('No support for historical code lookups!')
throw new Error('No support for historical code lookups!')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add currentBlockNumber and defaultBlock to the log and error messages?

@masonforest masonforest merged commit 495a7a2 into master Mar 24, 2020
@masonforest masonforest deleted the YAS-208/Synthetix/HistoricalCodeLookups branch April 7, 2020 11:54
gakonst added a commit that referenced this pull request Apr 12, 2021
* feat(hardhat-ovm): allow ignoring libraries when compiling

ethereum-optimism/plugins#39

* feat(batch-submitter): add logs

ethereum-optimism/batch-submitter#75
ethereum-optimism/batch-submitter#73

* chore: build contracts sequentially

this worsens our compilation times but ensures that the runs are not flaky
snario pushed a commit that referenced this pull request Apr 14, 2021
* Started proxy bridge

* Fix L1MessengerProxy deploy

* Attempt 2

* Fix bug in ResolvedDelegateProxy

* Fix bug in L1XDomainMessenger

* Reduce nodes in Merkle Trie tests

* Fix rebase error

* Add clarifying comment to delegate proxy

Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
* feat(hardhat-ovm): allow ignoring libraries when compiling

ethereum-optimism/plugins#39

* feat(batch-submitter): add logs

ethereum-optimism/batch-submitter#75
ethereum-optimism/batch-submitter#73

* chore: build contracts sequentially

this worsens our compilation times but ensures that the runs are not flaky
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025
gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025
blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025
BrycePy added a commit to gattaca-com/based-optimism that referenced this pull request Oct 10, 2025
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
* update env image tag

* set image to a solidity name

---------

Co-authored-by: louis.liu <louis.liu@okg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants