Conversation
|
|
||
| // TODO: Remove this function and use geth for lastL1BlockNumber! | ||
| private async _updateLastL1BlockNumber() { | ||
| this.log.warn('Calling _updateLastL1BlockNumber...') |
There was a problem hiding this comment.
^oo this is another spot i wanted an opinion on, i thought of putting warnings for all the functions we want to deprecate cc @karlfloersch @tynes whether we'll do that for this soon?
There was a problem hiding this comment.
@annieke shoot this function should be removed entirely — it was only used when Geth did not return an L1BlockNumber field. At this point this ( updateLastL1BlockNumber() ) is dead code
There was a problem hiding this comment.
@karlfloersch it's called in _generateSequencerBatchParams, should the line that calls it be removed? bc it still seems like it's doing something
|
Things I feel like are
|
|
@snario just did another pass adding those logs! |
| } | ||
|
|
||
| this.log.info('Generated sequencer batch params', { | ||
| contexts: sequencerBatchParams.contexts, |
There was a problem hiding this comment.
the contexts is quite small (in the test with 6 transactions), the transactions are actually the longer parts of this log here. i'll keep it and de-bloat if this ends up being too large?
| this.log.info('Retrieved start block number from CTC', { | ||
| startBlock, | ||
| }) |
There was a problem hiding this comment.
Might be useful to log both before and after this asynchronous network call for debugging purposes
Description
Doing a pass of logs to make sure we have more context while debugging. Let me know if there are other key areas that need more logs!
Additional context
Improve observability!
Metadata
https://github.com/ethereum-optimism/roadmap/issues/860