This repository was archived by the owner on Apr 11, 2021. It is now read-only.
add ignore file list on compilation#39
Merged
smartcontracts merged 3 commits intoethereum-optimism:masterfrom Apr 9, 2021
Merged
add ignore file list on compilation#39smartcontracts merged 3 commits intoethereum-optimism:masterfrom
smartcontracts merged 3 commits intoethereum-optimism:masterfrom
Conversation
added 3 commits
April 8, 2021 05:34
smartcontracts
approved these changes
Apr 9, 2021
Contributor
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM. Thank you!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
just an an optional 'ignore/skip' list(of regex) when doing compilation as libraries like @OpenZeppelin may not play nice with ovm compiler yet would be included by hardhat
use like this in the hardhat.config.js
networks: {
localhost_l1: {
url: networks.localhost.l1RpcUrl,
accounts,
ignoreRxList: ["ovmzeppelin/."]
},
localhost_l2: {
url: networks.localhost.l2RpcUrl,
accounts,
ovm:true,
ignoreRxList: ["@OpenZeppelin."]
},