Skip to content

Add a GitHub workflow for publishing to NPM#24

Merged
masonforest merged 2 commits intomasterfrom
YAS-175/RepoCleanup/ReworkNpmPublish
Feb 25, 2020
Merged

Add a GitHub workflow for publishing to NPM#24
masonforest merged 2 commits intomasterfrom
YAS-175/RepoCleanup/ReworkNpmPublish

Conversation

@masonforest
Copy link
Copy Markdown

@masonforest masonforest commented Feb 25, 2020

Description

Automates the process of deploying to npm.

Note this hasn't been tested yet. I'll run and debug it by merging to the published branch once it's merged into master.

Contributing Agreement

willmeister
willmeister approved these changes Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I'd ask is if there's an easy way to pull in and run another job from a different .github/workflows/job.yml file. It looks like this uses the other job as a pre-condition.

@masonforest
Copy link
Copy Markdown
Author

masonforest commented Feb 25, 2020

It doesn't look like that's currently possible 😕 -> https://github.community/t5/GitHub-Actions/Depend-on-another-workflow/m-p/32378/highlight/true#M1101

They suggest adding a workflow and only deploying (publishing in our case) if a PR has been merged. That way you know the tests have already previously passed in a separate workflow. Theoretically we shouldn't currently be able to merge to master with failing tests. Running the tests here is mostly a precaution. We could probably remove the lint and test steps from the deployment workflow here. Thoughts?

@willmeister
Copy link
Copy Markdown

willmeister commented Feb 25, 2020

It doesn't look like that's currently possible 😕 -> https://github.community/t5/GitHub-Actions/Depend-on-another-workflow/m-p/32378/highlight/true#M1101

They suggest adding a workflow and only deploying (publishing in our case) if a PR has been merged. That way you know the tests have already previously passed in a separate workflow. Theoretically we shouldn't currently be able to merge to master with failing tests. Running the tests here is mostly a precaution. We could probably remove the lint and test steps from the deployment workflow here. Thoughts?

We'll need a build, which includes installing deps, etc. Yeah, I agree, test and lint shouldn't be required. I just hate the idea of updating 2 different places to cache deps for a new package, but 🤷‍♂.

@masonforest masonforest merged commit 7e74844 into master Feb 25, 2020
masonforest added a commit that referenced this pull request Feb 25, 2020
@masonforest
Revert "Add a GitHub workflow for publishing to NPM (#24)"
3b44e77 
This reverts commit 7e74844.
@masonforest masonforest deleted the YAS-175/RepoCleanup/ReworkNpmPublish branch March 23, 2020 13:22
gakonst added a commit that referenced this pull request Apr 12, 2021
@gakonst
perf: improve contracts build time (#24)
5f2e00a 
* perf: improve contracts build time

* chore: clean tsconfig.buildinfo

* ci: try running CI
snario pushed a commit that referenced this pull request Apr 14, 2021
@smartcontracts
Adds CTC verification functions, removes BaseChain (#24)
6619834 
* Upgraded to new RingBuffer

* First pass at verification function

* Removed BaseChain as a contract

* Update OVM_CanonicalTransactionChain.spec.ts

* Removed unused chain variable

* Added overwriting logic to CTC

* Corrected CTC event emit

* Remove timebound ring buffer tests
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
@gakonst
perf: improve contracts build time (#24)
5a358c6 
* perf: improve contracts build time

* chore: clean tsconfig.buildinfo

* ci: try running CI
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
@boyuan-chen
Merge pull request #24 from enyalabs/dev_contract_url
72483c7 
Updated URL
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
@boyuan-chen
Merge pull request #24 from enyalabs/dev_contract_url
484b029 
Updated URL
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
@karlfloersch
Move the ToC to the top of readme (ethereum-optimism#24)
527dbcc
@mslipper mslipper mentioned this pull request May 16, 2022
Merged
max-sanchez referenced this pull request in hemilabs/optimism Apr 16, 2024
@max-sanchez
Squashed 'heminetwork/' changes from b3993a073..88047e707
690ee85 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 referenced this pull request in hemilabs/optimism Apr 17, 2024
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
b6b1308 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
@vitsalis
fix: Use the keyring directory from the Babylon configuration (ethere…
d9c18e5 
…um-optimism#24)
SozinM pushed a commit to NethermindEth/optimism that referenced this pull request Feb 10, 2025
@jinmel
Merge pull request ethereum-optimism#24 from flashbots/pbs-docker
ab12a22 
Update docker build for op-geth
ClaytonNorthey92 referenced this pull request in hemilabs/optimism Apr 4, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
f317a9a 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 referenced this pull request in hemilabs/optimism Apr 7, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
65c9bb8 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025
@syntrust
update gas (ethereum-optimism#24)
fb64053
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
@xzav3r
feat(test): make chainid configurable and use 196 by default (ethereu…
007d72c 
…m-optimism#24)
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
♻ Move pipe reading logic into pipe, so that it's shared (#24)
3a464f6
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
@Zena-park
Squashed commit of the following:
5dd0883 
commit 033b865
Author: Zena-park <zena@tokamak.network>
Date:   Wed Jul 10 19:37:02 2024 +0900

    refactor: delete try-catch statement ethereum-optimism#25

commit d5627e4
Author: Zena-park <zena@tokamak.network>
Date:   Tue Jul 9 15:52:29 2024 +0900

    test: setExplorer ethereum-optimism#24

commit f07c2db
Author: Zena-park <zena@tokamak.network>
Date:   Tue Jul 9 14:34:24 2024 +0900

    feat: setExplorer function ethereum-optimism#24
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
@Zena-park
feat: setExplorer function ethereum-optimism#24
f07c2db
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
@Zena-park
test: setExplorer ethereum-optimism#24
d5627e4
theochap pushed a commit that referenced this pull request Jan 15, 2026
@mattsse
Merge pull request #24 from alloy-rs/matt/downgrade-all-clippy
d10dd2e 
chore: downgrad clippy all
theochap pushed a commit that referenced this pull request Jan 21, 2026
@mattsse
Merge pull request #24 from alloy-rs/matt/downgrade-all-clippy
40fec2e 
chore: downgrad clippy all
theochap pushed a commit that referenced this pull request Jan 21, 2026
@Rimeeeeee
added const for arbitrum sepolia (alloy-rs/hardforks#27)
8f2eff9 
fixes #24
scharissis added a commit that referenced this pull request Feb 9, 2026
@scharissis
ci: bump circleci-utils to dev:sc-mise-v for testing mise update
c4ba95e 
Test the mise v2026.2.2 update from circleci-utils PR #24 in CI.
@scharissis scharissis mentioned this pull request Feb 9, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@willmeister willmeister willmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masonforest @willmeister