do not override timeout in ForReceiptMaybe#26
Merged
ClaytonNorthey92 merged 1 commit intohemifrom Nov 10, 2025
Merged
Conversation
optimism overrides context timeouts in (a lot of) test "wait" helper functions. one that we use use ForReceiptMaybe. the timeout is hard-coded to 2 minutes. but realistically when we "wait" sometimes what we're waiting for finishes in less than 2 minutes, sometimes longer. remove this override. use the context passed into the fuction for the timeout.
a4bdf88 to
515a73a
Compare
1 task
AL-CT
approved these changes
Nov 10, 2025
ClaytonNorthey92
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit 515a759.
ClaytonNorthey92
added a commit
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimism overrides context timeouts in (a lot of) test "wait" helper functions. one that we use use ForReceiptMaybe. the timeout is hard-coded to 2 minutes. but realistically when we "wait" sometimes what we're waiting for finishes in less than 2 minutes, sometimes longer.
remove this override. use the context passed into the fuction for the timeout.