Skip to content

gh actions: fix bumpage#316

Merged
tynes merged 1 commit intomasterfrom
fix-bumpage
Oct 7, 2020
Merged

gh actions: fix bumpage#316
tynes merged 1 commit intomasterfrom
fix-bumpage

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Oct 7, 2020

Description

Questions

Metadata

Fixes

  • Fixes # [Link to Issue]

Contributing Agreement

@tynes tynes merged commit f7716a2 into master Oct 7, 2020
@tynes tynes deleted the fix-bumpage branch October 7, 2020 18:34
snario pushed a commit that referenced this pull request Apr 14, 2021
…#316)

* perf: reset xDomainMessageSender to default value after external call

Fixes ethereum-optimism/contracts#309

We also set `xDomainMessageSender in the `initialize` function in L1, and in the L2 constructor.

* test: ensure that xDomainMessageSender is always 0xdead before/after calls

* chore: use parent constructor for initializing the L2 xdomain sender

* fix: require that the xDomainSender is not the default value
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
)

Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.13.14 to 1.13.15.
- [Release notes](https://github.com/ethereum/go-ethereum/releases)
- [Commits](ethereum/go-ethereum@v1.13.14...v1.13.15)

---
updated-dependencies:
- dependency-name: github.com/ethereum/go-ethereum
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
shenkeyao referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 1, 2025
* test(altda): add a test to make sure altda node keeps finalizing even after failover to ethda

Currently it does not, as shown by the test TestAltDA_FinalizationAfterEthDAFailover failing

* fix(damgr): ethda failover finalization stall bug

Weiwei from Polymer found this bug. He proposed a solution. This is an alternative solution which seems simpler, but not 100% of its soundness.

* fix: damgr_test doesn't compile

* chore: add more logs to damgr and altda_data_source

* docs(altda_test): fix typo

---------

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
QuentinI referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 7, 2025
* test(altda): add a test to make sure altda node keeps finalizing even after failover to ethda

Currently it does not, as shown by the test TestAltDA_FinalizationAfterEthDAFailover failing

* fix(damgr): ethda failover finalization stall bug

Weiwei from Polymer found this bug. He proposed a solution. This is an alternative solution which seems simpler, but not 100% of its soundness.

* fix: damgr_test doesn't compile

* chore: add more logs to damgr and altda_data_source

* docs(altda_test): fix typo

---------

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
OptimismBot pushed a commit that referenced this pull request Mar 11, 2025
QuentinI referenced this pull request in EspressoSystems/optimism-espresso-integration May 27, 2025
* test(altda): add a test to make sure altda node keeps finalizing even after failover to ethda

Currently it does not, as shown by the test TestAltDA_FinalizationAfterEthDAFailover failing

* fix(damgr): ethda failover finalization stall bug

Weiwei from Polymer found this bug. He proposed a solution. This is an alternative solution which seems simpler, but not 100% of its soundness.

* fix: damgr_test doesn't compile

* chore: add more logs to damgr and altda_data_source

* docs(altda_test): fix typo

---------

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
dailinsubjam referenced this pull request in EspressoSystems/optimism-espresso-integration Oct 4, 2025
* test(altda): add a test to make sure altda node keeps finalizing even after failover to ethda

Currently it does not, as shown by the test TestAltDA_FinalizationAfterEthDAFailover failing

* fix(damgr): ethda failover finalization stall bug

Weiwei from Polymer found this bug. He proposed a solution. This is an alternative solution which seems simpler, but not 100% of its soundness.

* fix: damgr_test doesn't compile

* chore: add more logs to damgr and altda_data_source

* docs(altda_test): fix typo

---------

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
theochap pushed a commit that referenced this pull request Jan 15, 2026
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Bump alloy to `0.12`
Closes #316 

<!--
Explain the context and why you're making that change. What is the
problem
you're trying to solve? In some cases there is not a problem and this
can be
thought of as being the motivation for your change.
-->

## Solution

- Bump alloy deps (using patch until 0.12 release)
- Bump alloy-core
- Impl RlpEcdsaEncodableTx for OpTypedTransaction

<!--
Summarize the solution and provide any necessary context needed to
understand
the code change.
-->

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
theochap pushed a commit that referenced this pull request Jan 21, 2026
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Bump alloy to `0.12`
Closes #316 

<!--
Explain the context and why you're making that change. What is the
problem
you're trying to solve? In some cases there is not a problem and this
can be
thought of as being the motivation for your change.
-->

## Solution

- Bump alloy deps (using patch until 0.12 release)
- Bump alloy-core
- Impl RlpEcdsaEncodableTx for OpTypedTransaction

<!--
Summarize the solution and provide any necessary context needed to
understand
the code change.
-->

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
emhane pushed a commit that referenced this pull request Feb 3, 2026
Fixes #316 

I also noticed a few `DatabaseError` that were being mapped to
`OpProofsStorageError::Other` and changed them to point to
`OpProofsStorageError::DatabaseError`

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant