Skip to content

Use an existing ExecutionManager if one has been deployed#48

Merged
masonforest merged 11 commits intomasterfrom
YAS-219/AWS/AddDockerFile
Mar 23, 2020
Merged

Use an existing ExecutionManager if one has been deployed#48
masonforest merged 11 commits intomasterfrom
YAS-219/AWS/AddDockerFile

Conversation

@masonforest
Copy link
Copy Markdown

Description

When running in production services may go down from time to time. This includes the rollup-fullnode. In the case that that service does fail and needs to be restarted we want to use the ExecutionManager contract that's already been deployed instead of deploying a new one every time it's restarted.

Metadata

Fixes

Contributing Agreement

Copy link
Copy Markdown

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a few stylistic / reusability comments.

stripZeros(hexlify(nonce))
]))).substring(26));

if(await provider.getCode(contractAddress) === "0x") {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be good to create a isHexStringEmptyOrUndefined(...) util function.

@masonforest masonforest merged commit 0918bf5 into master Mar 23, 2020
@masonforest masonforest deleted the YAS-219/AWS/AddDockerFile branch March 23, 2020 13:21
snario pushed a commit that referenced this pull request Apr 14, 2021
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025
* fix contracts-bedrock-tests-heavy-fuzz-modified

* fix empty test list

* rm empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants