Optimizing JUMP table PUSH32s by willmeister · Pull Request #37 · ethereum-optimism/optimism

willmeister · 2020-03-11T18:47:00Z

Description

Before this, all PUSHs for the JUMP table JUMPDESTs were PUSH32s. This makes them all PUSH2s.

Metadata

Fixes

Fixes # YAS-235

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

ben-chain

LGTM! One point of confusion in a test but approving.

ben-chain · 2020-03-11T19:09:56Z

packages/rollup-dev-tools/test/transpiler/transpile.jump.spec.ts

-      { opcode: Opcode.PUSH32, consumedBytes: bufferUtils.numberToBuffer(34) },
+      {
+        opcode: Opcode.PUSH1,
+        consumedBytes: bufferUtils.numberToBufferPacked(3, 2),


Maybe I'm missing something, but shouldn't this break since it's a PUSH1 but consumedBytes has minLength = 2?

ben-chain · 2020-03-11T19:24:00Z

packages/rollup-dev-tools/test/transpiler/constructor-transpilation.spec.ts

 const log = getLogger(`constructor-transpilation`)

-describe.only('Solitity contracts with constructors that take inputs should be correctly deployed', () => {
+describe('Solitity contracts with constructors that take inputs should be correctly deployed', () => {


- @eth-optimism/core-db@0.0.1-alpha.18 - @eth-optimism/core-utils@0.0.1-alpha.18 - @eth-optimism/docs@0.0.1-alpha.18 - @eth-optimism/optimistic-game-semantics@0.0.1-alpha.18 - @eth-optimism/ovm-truffle-provider-wrapper@0.0.1-alpha.18 - @eth-optimism/ovm@0.0.1-alpha.18 - @eth-optimism/rollup-contracts@0.0.1-alpha.18 - @eth-optimism/rollup-core@0.0.1-alpha.18 - @eth-optimism/rollup-dev-tools@0.0.1-alpha.18 - @eth-optimism/rollup-full-node@0.0.1-alpha.18 - @eth-optimism/solc-transpiler@0.0.1-alpha.18

* Use 'Block Derivation' rather than 'Block Generation' * Use 'L2 State Oracle' instead of 'L2 Block Hash Oracle'

88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10

* feat: add superchain erc20 baseline (#37) * feat: add superchain erc20 baseline * feat: make superchain ERC20 simpler * fix: small version fix and tests * test: fix test name * test: remove unused import * feat: making baseline abstract * fix: interfaces to comply with the new interface checker * fix: import paths and empty line * fix: lint line --------- Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>

* feat: add superchain erc20 baseline (ethereum-optimism#37) * feat: add superchain erc20 baseline * feat: make superchain ERC20 simpler * fix: small version fix and tests * test: fix test name * test: remove unused import * feat: making baseline abstract * fix: interfaces to comply with the new interface checker * fix: import paths and empty line * fix: lint line --------- Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>

88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10

…imism#37)

…sm#37

* feat(rpc-client): Introduce rpc-client crate * fix(rpc-client): jsonrpsee dep * fix(rpc-jsonrpsee): crate rename * fix(rpc-jsonrpsee): crate rename * fix(rpc-jsonrpsee): crate rename * fix(rpc-types): lints * fix(rpc-types): jsonrpsee dep * fix(rpc-jsonrpsee): exclude in github actions

making push32s for JUMP table just PUSH2s

e6ba748

ben-chain approved these changes Mar 11, 2020

View reviewed changes

willmeister added 2 commits March 11, 2020 15:38

PR feedback

fef0609

willmeister merged commit beb7138 into master Mar 11, 2020

willmeister deleted the YAS-235/ReplaceJUMPTablePUSH32s branch March 11, 2020 20:54

gakonst added a commit that referenced this pull request Apr 12, 2021

test: add erc20 tests (#37)

94baf79

snario pushed a commit that referenced this pull request Apr 14, 2021

deployer: log address manager address (#37)

fa5a259

InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021

test: add erc20 tests (#37)

183e790

protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022

Use better words (ethereum-optimism#37)

fb99795

* Use 'Block Derivation' rather than 'Block Generation' * Use 'L2 State Oracle' instead of 'L2 Block Hash Oracle'

mslipper mentioned this pull request May 16, 2022

Bedrock -> Develop #2563

Merged

blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025

remove reference of DEPOSITOR_ACCOUNT from SoulGasToken (ethereum-opt…

7f064b9

…imism#37)

theochap pushed a commit that referenced this pull request Dec 10, 2025

chore: scaffold (#37)

e13eea0

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

feat: Make OperatorManager's functions for withdrawal ethereum-optimi…

9768034

…sm#37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimizing JUMP table PUSH32s#37

Optimizing JUMP table PUSH32s#37
willmeister merged 3 commits intomasterfrom
YAS-235/ReplaceJUMPTablePUSH32s

willmeister commented Mar 11, 2020

Uh oh!

ben-chain left a comment

Uh oh!

ben-chain Mar 11, 2020

Uh oh!

ben-chain Mar 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

willmeister commented Mar 11, 2020

Description

Metadata

Fixes

Contributing Agreement

Uh oh!

ben-chain left a comment

Choose a reason for hiding this comment

Uh oh!

ben-chain Mar 11, 2020

Choose a reason for hiding this comment

Uh oh!

ben-chain Mar 11, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants