Conversation
| /* Internal Imports */ | ||
| import {DataTypes as dt} from "./DataTypes.sol"; | ||
|
|
||
| contract RollupMessagePasser { |
There was a problem hiding this comment.
This could probably be named a bit better. I really like L1ToL2Message because it indicates exactly how it is to be used. The same can be done for this class. If the intention is to ultimately invoke L2 functions, we could probably be more specific than message. Maybe something like OvmTxBridge or L2TransactionExecutor would be clearer? 🤷♂
There was a problem hiding this comment.
I also like L1ToL2MessagePasser. I think it's pretty conceptually easy to think of L1 and L2 as some abstract "parent" and "child" relationship between blockchains so maybe good to make use of that intuition.
Also, it is kind of interesting to replace message with transaction, but then again idk if that gets confusing with the already overloaded term....... But I guess "cross chain transaction" is already a thing. We could totally call this L1ToL2Transaction....
Anyway, I'm open to options!
karlfloersch
left a comment
There was a problem hiding this comment.
Left a couple comments but looks good! Impressive you got this BEAST of a PR working!!! 😁
Lol should have added deposits & withdrawals a long time ago lol
| solidity, | ||
| } from 'ethereum-waffle' | ||
|
|
||
| chai.use(solidity) |
There was a problem hiding this comment.
Is it possible to remove this? Also the chai = require('chai') bit. I think this should be handled by importing setup
| /* Internal Imports */ | ||
| import {DataTypes as dt} from "./DataTypes.sol"; | ||
|
|
||
| contract RollupMessagePasser { |
There was a problem hiding this comment.
I also like L1ToL2MessagePasser. I think it's pretty conceptually easy to think of L1 and L2 as some abstract "parent" and "child" relationship between blockchains so maybe good to make use of that intuition.
Also, it is kind of interesting to replace message with transaction, but then again idk if that gets confusing with the already overloaded term....... But I guess "cross chain transaction" is already a thing. We could totally call this L1ToL2Transaction....
Anyway, I'm open to options!
* refactor: move utils.ts to specific file * refactor: introduce watcher utils for x-domain monitoring * test: add rpc tests * fix: use injected l2 context and remove the unused ethsign methods
* refactor: move utils.ts to specific file * refactor: introduce watcher utils for x-domain monitoring * test: add rpc tests * fix: use injected l2 context and remove the unused ethsign methods
…ian/glossary Add glossary.md
…_input add UseInboxContract option
Co-authored-by: weixie.cui <weixie.cui@okg.com>
Description
Solves YAS-223 and creates a mocked message passer. Ran into some stupid event logging troubles, but even then I think we overdid the estimate on this one 😆
Metadata
Fixes
Contributing Agreement