Skip to content

Making revert messages flow through to the caller#35

Merged
willmeister merged 10 commits intomasterfrom
YAS-244/revertMessages
Mar 13, 2020
Merged

Making revert messages flow through to the caller#35
willmeister merged 10 commits intomasterfrom
YAS-244/revertMessages

Conversation

@willmeister
Copy link
Copy Markdown

Description

Makes revert messages flow through from the contract where the revert is called to the caller.

Metadata

Fixes

Contributing Agreement

 - @eth-optimism/core-db@0.0.1-alpha.19
 - @eth-optimism/core-utils@0.0.1-alpha.19
 - @eth-optimism/docs@0.0.1-alpha.19
 - @eth-optimism/optimistic-game-semantics@0.0.1-alpha.19
 - @eth-optimism/ovm-truffle-provider-wrapper@0.0.1-alpha.19
 - @eth-optimism/ovm@0.0.1-alpha.19
 - @eth-optimism/rollup-contracts@0.0.1-alpha.19
 - @eth-optimism/rollup-core@0.0.1-alpha.19
 - @eth-optimism/rollup-dev-tools@0.0.1-alpha.19
 - @eth-optimism/rollup-full-node@0.0.1-alpha.19
 - @eth-optimism/solc-transpiler@0.0.1-alpha.19
 - @eth-optimism/ovm-truffle-provider-wrapper@0.0.1-alpha.20
 - @eth-optimism/ovm@0.0.1-alpha.20
 - @eth-optimism/rollup-full-node@0.0.1-alpha.20
Copy link
Copy Markdown

@masonforest masonforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

_callBytes,
callSize,
returnData,
500000
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

 - @eth-optimism/core-db@0.0.1-alpha.21
 - @eth-optimism/core-utils@0.0.1-alpha.21
 - @eth-optimism/docs@0.0.1-alpha.21
 - @eth-optimism/optimistic-game-semantics@0.0.1-alpha.21
 - @eth-optimism/ovm-truffle-provider-wrapper@0.0.1-alpha.21
 - @eth-optimism/ovm@0.0.1-alpha.21
 - @eth-optimism/rollup-contracts@0.0.1-alpha.21
 - @eth-optimism/rollup-core@0.0.1-alpha.21
 - @eth-optimism/rollup-dev-tools@0.0.1-alpha.21
 - @eth-optimism/rollup-full-node@0.0.1-alpha.21
 - @eth-optimism/solc-transpiler@0.0.1-alpha.21
@willmeister willmeister merged commit dcba2f7 into master Mar 13, 2020
@willmeister willmeister deleted the YAS-244/revertMessages branch March 13, 2020 15:47
gakonst added a commit that referenced this pull request Apr 12, 2021
* ci: disable yarn install cache

* chore: use yarn test:ci to only test changes since master

* ci: use separate job for linting contracts

* feat(contracts): update to ethereum-optimism/contracts@06cdfb4

* feat(hardhat-ovm): replace env var with OVM config network

ethereum-optimism/plugins#35

* feat(batch-submitter): update to ethereum-optimism/batch-submitter@8cd92d4

* feat(dtl): update to https://github.com/ethereum-optimism/data-transport-layer/commit/b1e340a32bd6986ba2c381a10229d49c0b274648

More unit tests and slight type refactoring

* chore: regenerate yarn lock

* fix(integration-tests): use `--network optimism` instead of env var

* chore: yarn lint
snario pushed a commit that referenced this pull request Apr 14, 2021
* deployment: script

* deploy script: fix error message

* scripts: fixes

* deploy: update params

* deploy: lower inclusion period
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
* ci: disable yarn install cache

* chore: use yarn test:ci to only test changes since master

* ci: use separate job for linting contracts

* feat(contracts): update to ethereum-optimism/contracts@06cdfb4

* feat(hardhat-ovm): replace env var with OVM config network

ethereum-optimism/plugins#35

* feat(batch-submitter): update to ethereum-optimism/batch-submitter@8cd92d4

* feat(dtl): update to https://github.com/ethereum-optimism/data-transport-layer/commit/b1e340a32bd6986ba2c381a10229d49c0b274648

More unit tests and slight type refactoring

* chore: regenerate yarn lock

* fix(integration-tests): use `--network optimism` instead of env var

* chore: yarn lint
@github-actions github-actions bot mentioned this pull request Sep 20, 2022
SozinM pushed a commit to NethermindEth/optimism that referenced this pull request Feb 10, 2025
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
* add gray upgrade simulation for op-conductor

* update
theochap pushed a commit that referenced this pull request Dec 10, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
 const titan_info = {
  systemConfig : "0x1cA73f6E80674E571dc7a8128ba370b8470D4D87",
  type: 1,
  amount: ethers.BigNumber.from("1000100000000000000000"),
  flagTon: true,
  name: "Titan-sepolia",
  bridge: "0x1F032B938125f9bE411801fb127785430E7b3971",
  portal: "",
  l2TON: "0x7c6b91d9be155a6db01f749217d76ff02a7227f2"
}

const thanos_info = {
  systemConfig : "0xB8209Cc81f0A8Ccdb09238bB1313A039e6BFf741",
  type: 2,
  amount: ethers.BigNumber.from("1000100000000000000000"),
  flagTon: true,
  name: "Thanos-sepolia",
  bridge: "0x385076516318551d566CAaE5EC59c23fe09cbF65",
  portal: "0x7b6db1316e22167b56211cDDC33431098BaBC3c2",
  l2TON: "0xDeadDeAddeAddEAddeadDEaDDEAdDeaDDeAD0000"
}

titan_rollupConfigInfo [
  1,
  '0x7afEfd134118B7eCbF25F9E4e73C1aef8BE0603d',
  status: 1,
  operatorManager: '0x7afEfd134118B7eCbF25F9E4e73C1aef8BE0603d'
]
thanos_rollupConfigInfo [
  1,
  '0xEE85eD759BcE873e0946448a7Fa922A3f177955F',
  status: 1,
  operatorManager: '0xEE85eD759BcE873e0946448a7Fa922A3f177955F'
]
titan_CandidateAddOnInfo [
  '0x1cA73f6E80674E571dc7a8128ba370b8470D4D87',
  '0x4400458626eb4d7fc8f10811e9A2fB0A345a8875',
  rollupConfig: '0x1cA73f6E80674E571dc7a8128ba370b8470D4D87',
  candidateAddOn: '0x4400458626eb4d7fc8f10811e9A2fB0A345a8875'
]
thanos_CandidateAddOnInfo [
  '0xB8209Cc81f0A8Ccdb09238bB1313A039e6BFf741',
  '0x0e5417d597CC19abFb477Fa7e760AdcABDfe60E2',
  rollupConfig: '0xB8209Cc81f0A8Ccdb09238bB1313A039e6BFf741',
  candidateAddOn: '0x0e5417d597CC19abFb477Fa7e760AdcABDfe60E2'
]
theochap pushed a commit that referenced this pull request Jan 15, 2026
* added sync file with types from reth

* fixed import and added sync in lib

* made types optional

* Update crates/rpc-types/src/sync.rs

* touchups

* clippy

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap pushed a commit that referenced this pull request Mar 26, 2026
Fixes multiple deviations in kona's channel decompression (bug #35):

Zlib: replace unbounded decompress_to_vec_zlib with
decompress_to_vec_zlib_with_limit to prevent zip-bomb OOM. On limit
hit (HasMoreOutput), keep partial output per spec instead of rejecting.

Brotli: cap output buffer growth at max_rlp_bytes_per_channel instead
of erroring when the doubled buffer exceeds the limit. Fixes false
rejection of valid channels near the size limit.

Both: on decompression errors, preserve partial output so batches
decoded before the error point are accepted (matching Go reference).

Per spec: "If the decompressed data exceeds the limit, things proceed
as though the channel contained only the first
MAX_RLP_BYTES_PER_CHANNEL decompressed bytes."

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
theochap pushed a commit that referenced this pull request Mar 26, 2026
Fixes multiple deviations in kona's channel decompression (bug #35):

Zlib: replace unbounded decompress_to_vec_zlib with
decompress_to_vec_zlib_with_limit to prevent zip-bomb OOM. On limit
hit (HasMoreOutput), keep partial output per spec instead of rejecting.

Brotli: cap output buffer growth at max_rlp_bytes_per_channel instead
of erroring when the doubled buffer exceeds the limit. Fixes false
rejection of valid channels near the size limit.

Both: on decompression errors, preserve partial output so batches
decoded before the error point are accepted (matching Go reference).

Per spec: "If the decompressed data exceeds the limit, things proceed
as though the channel contained only the first
MAX_RLP_BYTES_PER_CHANNEL decompressed bytes."

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2026
* kona-client: fix trace-extension short-circuit at capped leaves

Fixes a bug where kona program could incorrectly treat a transition as
trace-extension and return early based solely on output-root equality,
even when the claimed L2 block number differed, enabling trivial wins
in dispute games.

* kona/client: Fix fmt & clippy (#456)

* kona-proof: fix TipCursor using zero output root instead of agreed prestate (#454)

This fixes an issue where the pipeline cursor was initialized with
B256::ZERO as the safe head output root. When the derivation pipeline
exhausts L1 data (EndOfSource) before deriving any new blocks, the
driver returns this zero value instead of the agreed prestate's actual
output root, causing the FPP to reject honest claims and accept zero
claims.

* fix(kona): bounded channel decompression with truncation per spec (#455)

Fixes multiple deviations in kona's channel decompression (bug #35):

Zlib: replace unbounded decompress_to_vec_zlib with
decompress_to_vec_zlib_with_limit to prevent zip-bomb OOM. On limit
hit (HasMoreOutput), keep partial output per spec instead of rejecting.

Brotli: cap output buffer growth at max_rlp_bytes_per_channel instead
of erroring when the doubled buffer exceeds the limit. Fixes false
rejection of valid channels near the size limit.

Both: on decompression errors, preserve partial output so batches
decoded before the error point are accepted (matching Go reference).

Per spec: "If the decompressed data exceeds the limit, things proceed
as though the channel contained only the first
MAX_RLP_BYTES_PER_CHANNEL decompressed bytes."

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: inphi <mlaw2501@gmail.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants