contracts: script for making markdown file with all our contract addresses#456
contracts: script for making markdown file with all our contract addresses#456
Conversation
|
121858a to
53146f5
Compare
packages/contracts/package.json
Outdated
There was a problem hiding this comment.
I wasn't sure of the best place to run it but figured it should happen here
There was a problem hiding this comment.
Probably should be part of the deploy script.
63daf96 to
52e0bde
Compare
snario
left a comment
There was a problem hiding this comment.
Instead of a column named Open could we just hyperlink the address of the contract to make the table width smaller?
I'd support this |
b76ad12 to
71f9850
Compare
| const chainId = Number( | ||
| fs.readFileSync(`./deployments/${deployment}/.chainId`) | ||
| ); | ||
| const network = networks[chainId]; |
There was a problem hiding this comment.
Could we add some sort of per-network annotations that can be injected into the markdown? E.g., kovan-v1 is outdated and will no longer be in use. We'll want to stop showing those addresses to people once we stop using the contracts. We probably want to add some sort of text to that section to make it clear that those contracts are deprecated. Also probably want to add the option to hide a deployment completely.
There was a problem hiding this comment.
Let's do this in a separate PR, if you have a specific idea could you please open an issue for it?
|
Also requesting that we add commit credits for @pakocrew |
71f9850 to
e32b665
Compare
|
I rebased and |
…esses (#456) * contracts: adds generate-markdown script for making markdown file with all our contract addresses * Moves generate-markdown to deploy script * Adds Goerli chain Id * Removes etherscan Open column Co-authored-by: Pacien Boisson <pakokrew@gmail.com>
* kona-client: fix trace-extension short-circuit at capped leaves Fixes a bug where kona program could incorrectly treat a transition as trace-extension and return early based solely on output-root equality, even when the claimed L2 block number differed, enabling trivial wins in dispute games. * kona/client: Fix fmt & clippy (#456) * kona-proof: fix TipCursor using zero output root instead of agreed prestate (#454) This fixes an issue where the pipeline cursor was initialized with B256::ZERO as the safe head output root. When the derivation pipeline exhausts L1 data (EndOfSource) before deriving any new blocks, the driver returns this zero value instead of the agreed prestate's actual output root, causing the FPP to reject honest claims and accept zero claims. * fix(kona): bounded channel decompression with truncation per spec (#455) Fixes multiple deviations in kona's channel decompression (bug #35): Zlib: replace unbounded decompress_to_vec_zlib with decompress_to_vec_zlib_with_limit to prevent zip-bomb OOM. On limit hit (HasMoreOutput), keep partial output per spec instead of rejecting. Brotli: cap output buffer growth at max_rlp_bytes_per_channel instead of erroring when the doubled buffer exceeds the limit. Fixes false rejection of valid channels near the size limit. Both: on decompression errors, preserve partial output so batches decoded before the error point are accepted (matching Go reference). Per spec: "If the decompressed data exceeds the limit, things proceed as though the channel contained only the first MAX_RLP_BYTES_PER_CHANNEL decompressed bytes." Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: inphi <mlaw2501@gmail.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Credit to Pacien Boisson @pakocrew
Please review carefully as this will be the source of truth for the near future