This repository was archived by the owner on Apr 11, 2021. It is now read-only.
use network.config.ovm#35
Merged
platocrat merged 1 commit intoethereum-optimism:masterfrom Apr 7, 2021
Merged
Conversation
Contributor
|
This looks awesome |
Contributor
|
@smartcontracts any idea for when this PR can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add an
ovmfield to the network config, removing the need for manipulating env variable and making it easier for user.They just need to specify that a particular network is ovm and then every compilation for that network will use the ovm artifact
Additional context
I modified the tutorial to reflect the usage of that modified plugin : ethereum-optimism/optimism-tutorial#18