Upgrade EUI to v26.3.1 by thompsongl · Pull Request #70243 · elastic/kibana

thompsongl · 2020-06-29T18:14:20Z

Summary

v24.1.0 ⏩ v26.3.1

Replaced KeyboardEvent.keyCode (deprecated) with KeyboardEvent.key
Extended Query / EuiSearchBar to allow any character inside double-quoted phrases
Optimized in-memory datagrid mount performance
Optimized performance of EuiToolTip during frequent mouesover/mouseout events

`26.3.1`

Added isClearable and placeholder options to EuiColorPicker (#3689)

`26.3.0`

Expanded EuiBasicTable's default action's name configuration to accept any React node (#3688)

`26.2.0`

Added background.color to EUI_CHARTS_THEME_LIGHT/DARK.theme (#3669)
Added gutterSize prop to EuiFacetGroup (#3639)
Updated props of EuiCode and EuiCodeBlock to reflect only functional props (#3647)
Updated EuiResizableContainer onPanelWidthChange callback method to include all panel widths (#3630)
Extended Query / EuiSearchBar to allow any character inside double-quoted phrases (#3432)
Added headerZindexLocation prop to EuiOverlayMask (#3655)
Added maskProps prop to EuiFlyout and EuiCollapsibleNav (#3655)

Bug fixes

Fixed EuiContextMenu panel onAnimationEnd transition bug in Chrome (#3656)
Fixed EuiSkipLink interactive props and Safari click issue (#3665)
Fixed z-index issues with EuiHeader, EuiFlyout, and other portal content (#3655)
Fixed color prop error in EuiBadge to be more flexible with what format it accepts (#3655)
Fixed EuiSuperSelect popover from moving 16px horizontally when it's close to a window edge (#3685)

Theme: Amsterdam

Fixed EuiHeaderBreadcrumb height, onClick, border-radius, and single item display (#3655)

`26.1.0`

Optimized in-memory datagrid mount performance (#3628)
Exported EuiCardProps and EuiCheckableCardProps types (#3640)

`26.0.1`

Bug fixes

Fixed fullscreen render issue in EuiCode (#3633)

`26.0.0`

Added useEuiTextDiff react hook utility (#3288)
Converted EuiOverlayMask to be a React functional component (#3555)
Changed responsive and max behavior of EuiBreadcrumbs to always display collapsed items in popover #3578)
Added BREAKPOINTS and getBreakpoint utilities #3578)
Added 'any' option to the step prop of the EuiFieldNumber (#3562)
Moved all EuiHeader SASS variables to global_styles (#3592)
Added side prop to EuiGlobalToastList for choosing which window side to display toasts (#3600)
Default titleSize get's implicitly set to 'm' for EuiEmptyPrompt (#3598)
Updated logoElastic to meet brand guidelines (#3613)
Allowed user to enter hexcode for colors in EuiStat (#3617)
Extended CommonProps in EuiColorPalettePickerPaletteTextProps, EuiColorPalettePickerPaletteFixedProps and EuiColorPalettePickerPaletteGradientProps types (#3616)
Updated onToggle callback in EuiAccordion to allow for external state control (#3614)

Bug fixes

Added display prop to EuiDataGridColumnSortingDraggable to pass displayAsText prop correctly to the column sorting popover.(#3574)
Fixed EuiCodeBlockImpl testenv mock pass-through of data-test-subj attribute (#3560)
Fixed DOM element creation issues in EuiOverlayMask by using lifecycle methods (#3555)
Fixed EuiComboBox's options list zIndex positioning when nested in other zIndex contexts (#3551)
Fixed euiHeaderAffordForFixed mixin's use of header SASS variable (#3592)
Included onClick as a valid prop for EuiControlBar icon controls (#3581)
Fixed poor performance of EuiToolTip during frequent mouesover/mouseout events (#3596)
Fixed EuiBasicTable custom actions popover from remaining open after click (#3619)

Breaking changes

Changed breadcrumb TS type exported name from Breadcrumb to EuiBreadcrumb (#3578)
Removed $euiZComboBox SCSS variable (value was 8001) (#3551)

Theme: Amsterdam

Updated EuiCallout by removing left border, adding border radius and increasing font weight on titles (#3557)
Updated EuiHeaderBreadcrumbs style to be more prominent (#3578)
Fixed EuiFilterGroup border-radius (#3591)
Updated EuiCodeBlock inline code style to use border radius (#3599)

`25.0.0`

Added conditional rendering of the title element in EuiCallOut to avoid usage of additional space caused by the rendered <div> element (#3549)
Added invalidCallout prop to EuiForm to allow conditional rendering of error callout(#3585)

Bug fixes

Fixed EuiCard image corners to be contained within border radius (#3556)
Fixed EuiKeyPadMenu and EuiKeyPadMenuItem aria roles (#3502)
Fixed EuiFieldSearch input clear button doesn't show when external input is passed(#3497)
Fixed EuiBasicTable footers to always use a unique key (#3559)
Fixed EuiInMemoryTable by changing the getDerivedStateFromProps to not block the updates as soon as it hits a true if condition (#3579)

Breaking changes

A fixed EuiHeader no longer automatically padding directly to the <body> element (#3538)
Improved EuiPagination, EuiDataGrid, EuiBasicTable and EuiInMemoryTable accessibility, causing EuiPaginationButton to require a new prop pageIndex (#3294)
Replaced all usages of KeyboardEvent.keyCode (deprecated) with KeyboardEvent.key. From @elastic/eui/lib/services, keyCodes has been replaced with keys, as has cascadingMenuKeyCodes->cascadingMenuKeys, and comboBoxKeyCodes->comboBoxKeys. The implementation of all of those exports (as well as accessibleClickKeys) all now use KeyboardEvent.key values. (#3517)

thompsongl · 2020-07-01T15:02:46Z

Update: Waiting on resolution of #70383

cjcenizal

ES UI changes look good. I tested the Console history, and the Ingest Node Pipelines inline editor and processor movement-canceling UX. I couldn't test the changes to use_ui_ace_keyboard_mode.ts since a regression (#71157) means that this functionality currently isn't working on master. Test changes look reasonable but I didn't dig deeply. I assume if they're passing then the changes are fine.

pgayvallet

LGTM for platform changes

lizozom

Code owner changes lgtm

kertal

KibanaApp owned Code LGTM 👍 , tested locally in Chrome, Firefox, Safari, fixes the issue described in #6990, scrolling in Firefox over elements with Tooltips is no longer causing the jumping back to top

XavierM

For Security Solutions

thomasneirynck

maps/* code review. LGTM. Thx!

thompsongl · 2020-07-09T15:51:48Z

@elasticmachine merge upstream

clintandrewhall

LGTM... thanks for updating the storyshot, too!

ryankeairns

Design pinged due to change in import path.

shahzad31

uptime changes LGTM !!

thompsongl · 2020-07-09T21:47:54Z

endpoint-app/siem codeowner overlap. Will merge on green.

thompsongl · 2020-07-09T22:55:57Z

@elasticmachine merge upstream

kibanamachine · 2020-07-10T00:38:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6100586

Build metrics

✅ unchanged

History

💔 Build #60490 failed 4daa32c
💔 Build #60452 failed c5776fc
💚 Build #60401 succeeded a4e5c92
💚 Build #60296 succeeded 40a30f4
💔 Build #60245 failed e47edb6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* eui to 26.1.0 * Breadcrumb -> EuiBreadcrumb * keyCode -> key * src snapshot updates * update header variables file location * keyCode -> key in tests * x-pack simple snapshot updates * euitooltip updates * euioverlaymask updates * testbed keycode -> key * fixed header sass mixin * euidatagrid test workaround * euioverlapmask mock * euipaginationbutton markup * nav snapshot update * eui to 26.3.0 * flyout z-index fix * euiflyout snapshot updates * style snapshot updates * table actions have machine readable text * table actions have machine readable text * core api docs update * table actions snapshot update * eui to 26.3.1 * update table actions type * mock issue links; timeout done * breadcrumb -> euibreadcrumb Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.test.ts # x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_utilities.tsx

* Upgrade EUI to v26.3.1 (#70243) * eui to 26.1.0 * Breadcrumb -> EuiBreadcrumb * keyCode -> key * src snapshot updates * update header variables file location * keyCode -> key in tests * x-pack simple snapshot updates * euitooltip updates * euioverlaymask updates * testbed keycode -> key * fixed header sass mixin * euidatagrid test workaround * euioverlapmask mock * euipaginationbutton markup * nav snapshot update * eui to 26.3.0 * flyout z-index fix * euiflyout snapshot updates * style snapshot updates * table actions have machine readable text * table actions have machine readable text * core api docs update * table actions snapshot update * eui to 26.3.1 * update table actions type * mock issue links; timeout done * breadcrumb -> euibreadcrumb Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.test.ts # x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_utilities.tsx * lint fix

…11y-overlay * 'master' of github.com:elastic/kibana: (33 commits) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI Deduplication of entries and items before sending to endpoint (elastic#71297) [services/remote/webdriver] fix eslint error (elastic#71346) send slack notifications on visual baseline failures fix visual regression job (elastic#70999) [Ingest Manager] Add schema to usageCollector. (elastic#71219) [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279) [Ingest Manager] Fix limited packages incorrect response (elastic#71292) Support multiple features declaring same properties (elastic#71106) [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183) [DOCS] Clarify trial subscription levels (elastic#70636) ...

* master: (78 commits) Bump lodash package version (elastic#71392) refactor: 💡 use allow-list in AppArch codebase (elastic#71400) improve bugfix 7198 test stability (elastic#71250) [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198) [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172) [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269) [Security Solution] Allow to configure Event Renderers settings (elastic#69693) Fix a11y keyboard overlay (elastic#71214) [APM] UI text updates (elastic#71333) [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113) [SIEM] fix tooltip of notes (elastic#71342) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) ...

thompsongl added 12 commits June 24, 2020 16:38

eui to 26.1.0

02e0ade

Breadcrumb -> EuiBreadcrumb

81e05fd

keyCode -> key

eddd72c

Merge branch 'master' into eui/26.1

b6a59ff

src snapshot updates

a73a609

update header variables file location

a3287dd

keyCode -> key in tests

04fe5cf

x-pack simple snapshot updates

f8488db

euitooltip updates

52285ff

euioverlaymask updates

c39043b

testbed keycode -> key

7e76f68

Merge branch 'master' into eui/26.1

8212ecd

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.9.0 labels Jun 29, 2020

thompsongl added 5 commits June 29, 2020 13:50

fixed header sass mixin

24accfb

euidatagrid test workaround

36b98b2

euioverlapmask mock

a28f4a1

euipaginationbutton markup

451ef61

Merge branch 'master' into eui/26.1

d1fa9e7

thompsongl mentioned this pull request Jun 30, 2020

[ML] Invalid actions pattern on Transforms management table #70383

Closed

thompsongl added the blocked label Jul 1, 2020

Merge branch 'master' into eui/26.1

5faa2f8

thompsongl added 3 commits July 2, 2020 08:45

Merge branch 'master' into eui/26.1

3945c51

nav snapshot update

f195d6a

eui to 26.3.0

6380529

thompsongl changed the title ~~Upgrade EUI to v26.1.0~~ Upgrade EUI to v26.3.0 Jul 2, 2020

walterra mentioned this pull request Jul 3, 2020

[ML] Transforms/DFA: Refactor list action buttons so modals won't unmount after button click. #70555

Merged

5 tasks

sorenlouv approved these changes Jul 8, 2020

View reviewed changes

cjcenizal approved these changes Jul 8, 2020

View reviewed changes

pgayvallet approved these changes Jul 9, 2020

View reviewed changes

lizozom approved these changes Jul 9, 2020

View reviewed changes

kertal approved these changes Jul 9, 2020

View reviewed changes

Merge branch 'master' into eui/26.1

e47edb6

XavierM approved these changes Jul 9, 2020

View reviewed changes

thomasneirynck approved these changes Jul 9, 2020

View reviewed changes

Merge branch 'master' into eui/26.1

40a30f4

clintandrewhall approved these changes Jul 9, 2020

View reviewed changes

ryankeairns approved these changes Jul 9, 2020

View reviewed changes

thompsongl added 2 commits July 9, 2020 12:02

Merge branch 'master' into eui/26.1

a4e5c92

Merge branch 'master' into eui/26.1

c5776fc

shahzad31 approved these changes Jul 9, 2020

View reviewed changes

thompsongl added 2 commits July 9, 2020 14:48

Merge branch 'master' into eui/26.1

3c1def8

breadcrumb -> euibreadcrumb

4daa32c

Merge branch 'master' into eui/26.1

6100586

thompsongl merged commit 9537a82 into elastic:master Jul 10, 2020

thompsongl mentioned this pull request Jul 10, 2020

[7.x] Upgrade EUI to v26.3.1 (#70243) #71359

Merged

jen-huang mentioned this pull request Jul 13, 2020

[Ingest Manager] Fix create agent config flyout being covered by bottom bar #71502

Merged

kertal mentioned this pull request Aug 6, 2020

Scrolling skips in discover when using Firefox #58204

Closed

walterra mentioned this pull request Aug 10, 2020

Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. #74642

Merged

2 tasks

Conversation

thompsongl commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

26.3.1

26.3.0

26.2.0

26.1.0

26.0.1

26.0.0

25.0.0

Uh oh!

thompsongl commented Jul 1, 2020

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Jul 9, 2020

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Jul 9, 2020

Uh oh!

thompsongl commented Jul 9, 2020

Uh oh!

kibanamachine commented Jul 10, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

thompsongl commented Jun 29, 2020 •

edited

Loading

`26.3.1`

`26.3.0`

`26.2.0`

`26.1.0`

`26.0.1`

`26.0.0`

`25.0.0`