[Amsterdam] Added rounded corners to inline EuiCode#3599
Merged
cchaos merged 6 commits intoelastic:masterfrom Jun 12, 2020
Merged
[Amsterdam] Added rounded corners to inline EuiCode#3599cchaos merged 6 commits intoelastic:masterfrom
cchaos merged 6 commits intoelastic:masterfrom
Conversation
cchaos
reviewed
Jun 11, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3599/ |
cchaos
reviewed
Jun 11, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3599/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3599/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small PR for EUI Amsterdam theme that adds rounded corners to inline versions of EuiCodeBlock. It is a very subtle change, but gives it a little more personality. I opted not to use
$euiBorderRadius(6px) and instead used$euiSizeXS(4px) because the larger radius made the shape look too much like a pill.Screenshot
Checklist
[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes