Added side property to 'EuiGlobalToastList' #3600
Conversation
…o change the side of the toast
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
anishagg17
left a comment
There was a problem hiding this comment.
We can have a new test for this prop
|
@anishagg17 just the snapshot tests, right? |
Yep ! |
|
@anishagg17 updated the test and the snapshot :) |
|
@cchaos Done |
cchaos
left a comment
There was a problem hiding this comment.
Getting closer. A few more tweaks. Also don't forget to add a changelog entry
|
@cchaos Updated changes, could you review them? |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3600/ |
|
@cchaos they failed :( you know the reason? |
|
It's because I pushed a commit changing the name of the test. We'll need to re-run the snapshots again. Though I'm currently working about a problem we seem to have with the styles and will end up pushing some style commits |
|
Oh alright, Do I need to update something? @cchaos |
- Removed visibility of scrollbar for toasts list - Fixed padding for visibility of toast shadow
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3600/ |
|
@cchaos :) |
Summary
Added the
sideproperty toEuiGlobalToastListto allow the user to place the toasts left or right instead of just the default rightChecklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modesfixes #3435
@cchaos @chandlerprall