Skip to content

Table cells should have a way to turn off text mode #2

@bevacqua

Description

@bevacqua

In this snippet:

<span className="kuiTableCellContent__text">

The issue is that when we want to render full-width cells such as Node distribution in the following table:

screen shot 2017-10-23 at 11 41 15

We need to do something like .ourTable .kuiTableCellContent__text { width: 100% }. Is this reasonable, or should we have a prop to turn off the text mode, whereby we don't add the extra span highlighted here:

screen shot 2017-10-23 at 11 43 22

I'd rather not have consumers need to dig into the internal classes as much as possible (in the context of React components at least), since that's the value in React for the most part, abstracting the classes away

In conclusion, would it be possible to do something like:

{
  this.props.allowOverflow === true
    ? children
    : <span className='kuiTableCellContent__text'>{ children }</span>
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions