[EuiCodeBlockImpl] Handle data-test-subj in testenv mock#3560
Merged
thompsongl merged 3 commits intoelastic:masterfrom Jun 5, 2020
Merged
[EuiCodeBlockImpl] Handle data-test-subj in testenv mock#3560thompsongl merged 3 commits intoelastic:masterfrom
data-test-subj in testenv mock#3560thompsongl merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Would you mind verifying (if you hadn't already) that |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3560/ |
Contributor
Author
All good. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3560/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3483 by passing
data-test-subjthrough to the child element inEuiCodeBlockImpltestenv instances.Will help revert some less-than-ideal workarounds in Kibana introduced in a previous update.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes