Skip to content

Upgrade elastic charts 19.6.3#3669

Merged
cchaos merged 5 commits intoelastic:masterfrom
nickofthyme:upgrade-elastic-charts
Jun 29, 2020
Merged

Upgrade elastic charts 19.6.3#3669
cchaos merged 5 commits intoelastic:masterfrom
nickofthyme:upgrade-elastic-charts

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme commented Jun 29, 2020 •
edited
Loading

Summary

  • upgrade elastic charts to 19.6.3
  • add background.color to eui chart theme

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@nickofthyme
upgrade elastic charts
5ce222e 
- upgrade elastic charts to 19.6.1
- add background.color to eui chart theme
@nickofthyme nickofthyme requested a review from cchaos June 29, 2020 15:46
@nickofthyme nickofthyme changed the title upgrade elastic charts Upgrade elastic charts Jun 29, 2020
@nickofthyme nickofthyme changed the title Upgrade elastic charts Upgrade elastic charts 19.6.1 Jun 29, 2020
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jun 29, 2020

Thanks @nickofthyme ! Since this updates a peer-dependency and a consumed output file, it will need a changelog.

@nickofthyme
Copy link
Copy Markdown
Contributor Author

nickofthyme commented Jun 29, 2020

Ok thanks, I added a note about the src changes.

I wasn't sure what you meant by the peer dependency changes because none of the peer dependencies of @elastic/eui have changed. Are you talking about adding @popperjs/core and chroma-js? If so what should I add?

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Jun 29, 2020 •
edited
Loading

Pulled up the package.json & yarn.lock changes and compared with our devDeps & peerDeps, this change only affects the former and not peerDeps. No changelog needed (for that change, the background color one is still needed as you have it), but thank you @cchaos for thinking of it!

@nickofthyme nickofthyme changed the title Upgrade elastic charts 19.6.1 Upgrade elastic charts 19.6.3 Jun 29, 2020
@nickofthyme
Copy link
Copy Markdown
Contributor Author

nickofthyme commented Jun 29, 2020

Ok thanks for the clarification. Thanks @chandlerprall and @cchaos for the review! 👍

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jun 29, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/

cchaos
cchaos approved these changes Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll eventually revisit how we are actually doing this and probably want document it. I'll make a note or issue for follow-up.

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jun 29, 2020

Meant to also say THANK YOU @nickofthyme !

@nickofthyme @cchaos
Update CHANGELOG.md
a646a35 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jun 29, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/

@cchaos cchaos merged commit 86d4497 into elastic:master Jun 29, 2020
@nickofthyme nickofthyme deleted the upgrade-elastic-charts branch July 2, 2020 13:48
@thompsongl thompsongl mentioned this pull request Jul 2, 2020
Merged
@elizabetdev elizabetdev mentioned this pull request Jul 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickofthyme @cchaos @chandlerprall @kibanamachine