Sent all the panel sizes via onPanelWidthChange in EuiResizableComponent rather than just the 2 panel sizes#3630
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
You're adding the size of the panels as pixels, where the existing Also,
|
|
@chandlerprall Yeah, I forgot to fix the lint errors, sorry, I used git commit -m "" -n as the usual commit used to take too much time
|
|
@chandlerprall I've fixed the lint error and the percentages, could you review it |
|
This point still needs to be addressed
When setting |
|
@thompsongl Yeah, I did notice that, but I think when user uses the |
This is how the component currently works, but the goal of the issue is to change that behavior. When The use case is that a consumer might want to perform a side effect with the panel width values (provided by the |
|
@thompsongl Okay, on it :) |
|
@thompsongl Done, Is this what was needed? |
|
@thompsongl |
No, the |
Yeah, So Do I need to make any changes now? |
thompsongl
left a comment
There was a problem hiding this comment.
About ready! Still needs a changelog entry
|
@thompsongl Done :) |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3630/ |
|
@thompsongl tests passed :) |
|
@thompsongl any updates? |
Summary
Sending all the panel sizes via the
onPanelWidthChangefunction inEuiResizableComponentrather than just the size for the 2 panels.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes@thompsongl @chandlerprall the
onPanelWIdthChangefunction does return all the values, you can check it by logging it in the 3 panel example, but there's some issue with the value, what do you suggest?onPanelWidthChange for EuiResizeableContainer only provides sizes for two panels #3466