[EuiOverlayMask] Prevent duplicate render and allow use in strict mode#3555
Merged
thompsongl merged 9 commits intoelastic:masterfrom Jun 5, 2020
Merged
[EuiOverlayMask] Prevent duplicate render and allow use in strict mode#3555thompsongl merged 9 commits intoelastic:masterfrom
thompsongl merged 9 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
chandlerprall
suggested changes
Jun 4, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
chandlerprall
suggested changes
Jun 5, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
One last thing, otherwise looks great!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3555/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3437 by converting EuiOverlayMask to be a functional component and using lifecycle events (via
useEffect) to create and modify DOM elements for React portal use.Refactor and exposure of props interface, also.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes