Skip to content

[DOCS] Clarify trial subscription levels#70636

Merged
lcawl merged 4 commits intoelastic:masterfrom
lcawl:licence
Jul 9, 2020
Merged

[DOCS] Clarify trial subscription levels#70636
lcawl merged 4 commits intoelastic:masterfrom
lcawl:licence

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Jul 2, 2020 •
edited
Loading

Summary

This PR fixes the documentation that implies a trial licence maps to a platinum subscription. It also improves some licence-related text to align with the style guide.

Depends on elastic/docs#1886

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

Preview

https://kibana_70636.docs-preview.app.elstc.co/guide/en/kibana/master/managing-licenses.html

@lcawl lcawl requested review from bytebilly and gchaps July 2, 2020 18:21
This was referenced Jul 2, 2020
Merged
Merged
@lcawl lcawl marked this pull request as ready for review July 2, 2020 21:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 2, 2020

Pinging @elastic/kibana-docs (Team:Docs)

bytebilly
bytebilly requested changes Jul 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bytebilly bytebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcawl some comments that are mostly aligned with the ones for ES.

docs/management/managing-licenses.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@bytebilly bytebilly Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reinforce that our trial is free with something like you can activate a 30-day trial for free (or free trial).

docs/management/managing-licenses.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@bytebilly bytebilly Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could link to https://www.elastic.co/trialextension instead of the email address.

@lcawl lcawl mentioned this pull request Jul 6, 2020
Merged
2 tasks
cjcenizal
cjcenizal reviewed Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment!

docs/management/managing-licenses.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rendered as "refer to subscriptions"? Personally, I think "refer to the subscriptions page" sounds clearer.

Copy link
Copy Markdown
Member Author

@lcawl lcawl Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It resolves to the URL (i.e. "refer to https://www.elastic.co/subscriptions"). We don't have style guidelines for using URLs vs titles, but I tend to like using the URL for "external" links like that.

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for explaining!

gchaps
gchaps approved these changes Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/management/managing-licenses.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@gchaps gchaps Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this image need to be updated?

Copy link
Copy Markdown
Member Author

@lcawl lcawl Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good call. I'll update it after #70900 is merged.

bytebilly
bytebilly approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bytebilly bytebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lcawl lcawl removed the v7.7.2 label Jul 9, 2020
@lcawl lcawl merged commit 5e9f333 into elastic:master Jul 9, 2020
@lcawl lcawl deleted the licence branch July 9, 2020 20:19
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 9, 2020
@lcawl
[DOCS] Clarify trial subscription levels (elastic#70636)
43b2ea1
@lcawl lcawl mentioned this pull request Jul 9, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 9, 2020
@lcawl
[DOCS] Clarify trial subscription levels (elastic#70636)
e0c2a2d
@lcawl lcawl mentioned this pull request Jul 9, 2020
Merged
lcawl added a commit that referenced this pull request Jul 9, 2020
@lcawl
[DOCS] Clarify trial subscription levels (#70636) (#71315)
98b716f
lcawl added a commit that referenced this pull request Jul 9, 2020
@lcawl
[DOCS] Clarify trial subscription levels (#70636) (#71316)
119bb40
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console/fix-a…
b605b6b 
…11y-overlay

* 'master' of github.com:elastic/kibana: (33 commits)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI
  Deduplication of entries and items before sending to endpoint (elastic#71297)
  [services/remote/webdriver] fix eslint error (elastic#71346)
  send slack notifications on visual baseline failures
  fix visual regression job (elastic#70999)
  [Ingest Manager] Add schema to usageCollector. (elastic#71219)
  [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279)
  [Ingest Manager] Fix limited packages incorrect response (elastic#71292)
  Support multiple features declaring same properties (elastic#71106)
  [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183)
  [DOCS] Clarify trial subscription levels (elastic#70636)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bytebilly bytebilly bytebilly approved these changes

+2 more reviewers

@cjcenizal cjcenizal cjcenizal left review comments

@gchaps gchaps gchaps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.8.1 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lcawl @elasticmachine @cjcenizal @gchaps @bytebilly