[savedObjects field count] run in baseline job#70999
Merged
spalger merged 1 commit intoelastic:masterfrom Jul 7, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
reviewed
Jul 7, 2020
| # source "test/scripts/jenkins_xpack_page_load_metrics.sh" | ||
|
|
||
| cd "$XPACK_DIR" | ||
| source "$KIBANA_DIR/test/scripts/jenkins_xpack_saved_objects_field_metrics.sh" |
Contributor
There was a problem hiding this comment.
isn't test/scripts/jenkins_xpack_visual_regression.sh going to be called outside of the baseline job?
If so, jenkins_xpack_saved_objects_field_metrics.sh is run elsewhere, so would run twice
Contributor
Author
There was a problem hiding this comment.
It isn't currently, and we won't be re-enabling the visual regression tests on master/PRs until after I've refactored the baseline job (and a few other blockers are resolved) so I don't think it's a serious issue.
Contributor
Author
There was a problem hiding this comment.
Definitely crufty though
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
brianseeders
approved these changes
Jul 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 8, 2020
* master: (36 commits) fixed api url in example plugin (elastic#70934) [data.search.aggs]: Remove remaining client dependencies (elastic#70251) [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998) [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639) [SIEM][Detection Engine][Lists] Adds additional data types to value based lists [SIEM][Detection Engine][Lists] Removes feature flag for lists [APM] Show license callout in ML settings (elastic#70959) Migrate service settings test to jest (elastic#70992) [APM] Add cloud attributes to data telemetry (elastic#71008) Fix breadcrumb on panels for visibility / round corners (elastic#71010) Improve search typescript (elastic#69333) [savedObjects field count] run in baseline job (elastic#70999) [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988) [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874) [APM] Add API tests (elastic#70740) [Security Solution][Exceptions] - Tie server and client code together (elastic#70918) [Audit Logging] Add AuditTrail service (elastic#69278) [Usage Collection] Ensure no type duplicates (elastic#70946) [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958) [CI] Add pipeline task queue framework and merge workers into one (elastic#64011) ...
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 8, 2020
This reverts commit 53ee7a7.
spalger
added a commit
that referenced
this pull request
Jul 8, 2020
* Revert "temporarily disable firefox functional tests in PRs (#71116)" This reverts commit 54bd07f. * Revert "[savedObjects field count] run in baseline job (#70999)" This reverts commit 53ee7a7. * Revert "[CI] Add pipeline task queue framework and merge workers into one (#64011)" This reverts commit 465ed21. * Revert revert of change to jenkins_xpack_visual_regression.sh Co-authored-by: spalger <spalger@users.noreply.github.com>
Contributor
Author
|
Reverted a tiny portion of this that touched the new |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jul 9, 2020
This reverts commit 53ee7a7.
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 9, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # vars/tasks.groovy
spalger
added a commit
that referenced
this pull request
Jul 9, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 9, 2020
(cherry picked from commit 3153dff)
spalger
added a commit
that referenced
this pull request
Jul 9, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 10, 2020
…11y-overlay * 'master' of github.com:elastic/kibana: (33 commits) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI Deduplication of entries and items before sending to endpoint (elastic#71297) [services/remote/webdriver] fix eslint error (elastic#71346) send slack notifications on visual baseline failures fix visual regression job (elastic#70999) [Ingest Manager] Add schema to usageCollector. (elastic#71219) [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279) [Ingest Manager] Fix limited packages incorrect response (elastic#71292) Support multiple features declaring same properties (elastic#71106) [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183) [DOCS] Clarify trial subscription levels (elastic#70636) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added saved object field count metrics in #70580 but didn't add it to the baseline job, so there are sometimes metrics available from master and sometimes not. This adds the task to the
test/scripts/jenkins_xpack_visual_regression.shscript so that it runs against a version of Kibana with xpack included.