Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
commented
Jul 5, 2020
x-pack/plugins/apm/server/lib/services/get_services/get_services_items.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
retest |
25523a2 to
6b54778
Compare
smith
approved these changes
Jul 6, 2020
Contributor
smith
left a comment
There was a problem hiding this comment.
I had a few nits but this looks great and works for me.
I like to use this site for guidelines about how to write good tests, even though it's RSpec-specific. Not using "should" makes the output read better: http://www.betterspecs.org/#should
x-pack/test/apm_api_integration/basic/tests/services/top_services.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/top_services.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Is it a bug in the API that we don't have a stable sort order? No need to change here, but maybe we should open a ticket.
Contributor
Author
There was a problem hiding this comment.
I actually first fixed it at the source :D
x-pack/test/apm_api_integration/basic/tests/services/transactions/agent_name.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/agent_name.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/transaction_charts.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/transaction_charts.ts
Outdated
Show resolved
Hide resolved
sorenlouv
commented
Jul 7, 2020
Contributor
Author
There was a problem hiding this comment.
@dgieselaar would it be better to have a helper that infers the params from a route? Like:
type AgentConfigSearchParams = RouteParams<typeof agentConfigurationSearchRoute>
Contributor
There was a problem hiding this comment.
Sure, you can possibly extract such a helper from the typings we have today. I'm thinking about making params a io-ts type as well (rather than a record of io-ts types), and then it will be even easier.
Contributor
Author
|
retest |
9b8456e to
95d684f
Compare
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 7, 2020
sorenlouv
added a commit
that referenced
this pull request
Jul 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 8, 2020
* master: (36 commits) fixed api url in example plugin (elastic#70934) [data.search.aggs]: Remove remaining client dependencies (elastic#70251) [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998) [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639) [SIEM][Detection Engine][Lists] Adds additional data types to value based lists [SIEM][Detection Engine][Lists] Removes feature flag for lists [APM] Show license callout in ML settings (elastic#70959) Migrate service settings test to jest (elastic#70992) [APM] Add cloud attributes to data telemetry (elastic#71008) Fix breadcrumb on panels for visibility / round corners (elastic#71010) Improve search typescript (elastic#69333) [savedObjects field count] run in baseline job (elastic#70999) [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988) [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874) [APM] Add API tests (elastic#70740) [Security Solution][Exceptions] - Tie server and client code together (elastic#70918) [Audit Logging] Add AuditTrail service (elastic#69278) [Usage Collection] Ensure no type duplicates (elastic#70946) [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958) [CI] Add pipeline task queue framework and merge workers into one (elastic#64011) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #70739