Revert #64011 and subsequent fixes#71137
Merged
spalger merged 4 commits intoelastic:masterfrom Jul 8, 2020
Merged
Conversation
tylersmalley
approved these changes
Jul 8, 2020
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jul 9, 2020
This reverts commit b6a06df.
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a couple issues caused by #64011, and while I would really like to fix it rather than revert it, I don't have a ton of confidence that we'll be able to fix it before things heat up a lot for feature freeze. As such, I think we should probably revert it.