CI Reporter for saved objects field count by rudolf · Pull Request #70580 · elastic/kibana

rudolf · 2020-07-02T12:06:15Z

Summary

Introduces CI metrics for Saved Object field count broken down by Saved Object type. This will help teams review the impact their PR has on the field count and allow us to track this metric over time.

Known limitations:

New plugins are often developed behind a "feature flag" by setting the plugin's enabled config to default to false. Fields contributed by these plugins won't show up in these metrics. We will need a way to start Kibana with all discovered plugins enabled which would either require moving this to a jest_integration test using test_utils and internal API's or exposing a command line flag.
These numbers should be considered as a reference point only. Saved Objects should reduce the migrationVersion field count #70815 Can introduce an additional ~114 fields and if users have upgraded from older versions of Kibana they can have additional fields on their .kibana that's not present when testing a clean index Saved Object Migrations should clean up unused mappings #67086.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-07-03T14:09:29Z

Pinging @elastic/kibana-platform (Team:Platform)

spalger · 2020-07-03T17:59:47Z

@elasticmachine merge upstream

x-pack/test/saved_objects_field_count/runner.ts

This reverts commit 8c0126b.

spalger · 2020-07-04T08:03:29Z

Would be really cool if we could attribute unique fields to a specific plugin and shared fields separately...

rudolf · 2020-07-06T07:32:15Z

Would be really cool if we could attribute unique fields to a specific plugin and shared fields separately...

Yeah, as a first step we could track unique fields per type which would allow us to infer the plugin that added these.

x-pack/test/saved_objects_field_count/runner.ts

spalger · 2020-07-06T16:59:13Z

x-pack/test/saved_objects_field_count/runner.ts

+
+  await Promise.all(
+    fieldCountPerType
+      .sort((a, b) => a[0].localeCompare(b[0]))


We also sort things server-side

x-pack/test/saved_objects_field_count/runner.ts

x-pack/test/saved_objects_field_count/config.ts

x-pack/test/saved_objects_field_count/runner.ts

x-pack/test/saved_objects_field_count/config.ts

x-pack/test/saved_objects_field_count/runner.ts

rudolf · 2020-07-07T11:41:29Z

@elasticmachine merge upstream

kibanamachine · 2020-07-07T13:23:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 141bb9e

Build metrics

Saved Objects .kibana field count

id	value	diff	baseline
action	5	+5	-
action_task_params	3	+3	-
alert	22	+22	-
apm-indices	8	+8	-
apm-telemetry	238	+238	-
application_usage_transactional	2	+2	-
canvas-element	8	+8	-
canvas-workpad	5	+5	-
canvas-workpad-template	8	+8	-
cases	32	+32	-
cases-comments	17	+17	-
cases-configure	14	+14	-
cases-user-actions	10	+10	-
config	2	+2	-
dashboard	17	+17	-
endpoint:user-artifact	10	+10	-
endpoint:user-artifact-manifest	3	+3	-
epm-packages	8	+8	-
exception-list	35	+35	-
exception-list-agnostic	35	+35	-
file-upload-telemetry	2	+2	-
fleet-agent-actions	6	+6	-
fleet-agent-events	11	+11	-
fleet-agents	23	+23	-
fleet-enrollment-api-keys	10	+10	-
graph-workspace	9	+9	-
index-pattern	10	+10	-
infrastructure-ui-source	21	+21	-
ingest_manager_settings	5	+5	-
ingest-agent-configs	11	+11	-
ingest-outputs	10	+10	-
ingest-package-configs	35	+35	-
inventory-view	40	+40	-
kql-telemetry	3	+3	-
lens	7	+7	-
lens-ui-telemetry	5	+5	-
map	7	+7	-
metrics-explorer-view	22	+22	-
ml-telemetry	3	+3	-
namespace	1	+1	-
namespaces	1	+1	-
query	6	+6	-
references	4	+4	-
sample-data-telemetry	3	+3	-
search	9	+9	-
siem-detection-engine-rule-actions	8	+8	-
siem-detection-engine-rule-status	12	+12	-
siem-ui-timeline	86	+86	-
siem-ui-timeline-note	8	+8	-
siem-ui-timeline-pinned-event	7	+7	-
space	9	+9	-
telemetry	9	+9	-
timelion-sheet	13	+13	-
tsvb-validation-telemetry	2	+2	-
type	1	+1	-
ui-metric	2	+2	-
updated_at	1	+1	-
upgrade-assistant-reindex-operation	15	+15	-
upgrade-assistant-telemetry	13	+13	-
uptime-dynamic-settings	4	+4	-
url	6	+6	-
visualization	9	+9	-
total	-	+951	-

History

💔 Build #59313 failed 73bffb3
💚 Build #59118 succeeded 75c5ec0
💚 Build #59107 succeeded 4b586cb
💚 Build #59002 succeeded 54a2e66
💚 Build #58722 succeeded 60225f5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* CI Reporter for saved objects field count * Metrics needs to be an array * Fix type failures * Link to field count issue * Revert "Link to field count issue" This reverts commit 8c0126b. * Break down field count per type * Don't log total metric as metrics report already calculates this * Add saved objects field count ci metrics test to codeowners * Address review comments * Add field count CI metrics for disabled plugins Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS

* CI Reporter for saved objects field count (#70580) * CI Reporter for saved objects field count * Metrics needs to be an array * Fix type failures * Link to field count issue * Revert "Link to field count issue" This reverts commit 8c0126b. * Break down field count per type * Don't log total metric as metrics report already calculates this * Add saved objects field count ci metrics test to codeowners * Address review comments * Add field count CI metrics for disabled plugins Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS * Don't backport CODEOWNERS file to 7.x

rudolf added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:Saved Objects v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 2, 2020

CI Reporter for saved objects field count

e09c77b

rudolf force-pushed the so-field-count-ci-reporter branch from 3d78ad8 to e09c77b Compare July 2, 2020 12:08

rudolf added 3 commits July 3, 2020 09:15

Metrics needs to be an array

9f4f3fb

Fix type failures

b62fadd

Link to field count issue

8c0126b

rudolf marked this pull request as ready for review July 3, 2020 14:09

rudolf requested a review from spalger July 3, 2020 16:39

Merge branch 'master' into so-field-count-ci-reporter

8c2434c

spalger reviewed Jul 3, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Outdated Show resolved Hide resolved

Revert "Link to field count issue"

60225f5

This reverts commit 8c0126b.

rudolf added 2 commits July 6, 2020 17:07

Break down field count per type

c300fa3

Merge branch 'master' into so-field-count-ci-reporter

54a2e66

spalger reviewed Jul 6, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Outdated Show resolved Hide resolved

spalger reviewed Jul 6, 2020

View reviewed changes

rudolf added 2 commits July 6, 2020 20:00

Don't log total metric as metrics report already calculates this

4b586cb

Add saved objects field count ci metrics test to codeowners

75c5ec0

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Outdated Show resolved Hide resolved

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Show resolved Hide resolved

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/config.ts Outdated Show resolved Hide resolved

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Outdated Show resolved Hide resolved

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/config.ts Show resolved Hide resolved

mshustov reviewed Jul 7, 2020

View reviewed changes

x-pack/test/saved_objects_field_count/runner.ts Outdated Show resolved Hide resolved

mshustov approved these changes Jul 7, 2020

View reviewed changes

rudolf added 2 commits July 7, 2020 11:57

Address review comments

9efdb56

Add field count CI metrics for disabled plugins

73bffb3

Merge branch 'master' into so-field-count-ci-reporter

141bb9e

rudolf merged commit 2f905e7 into elastic:master Jul 7, 2020

rudolf deleted the so-field-count-ci-reporter branch July 7, 2020 14:53

rudolf mentioned this pull request Jul 7, 2020

[7.x] CI Reporter for saved objects field count (#70580) #70969

Merged

spalger mentioned this pull request Jul 7, 2020

[savedObjects field count] run in baseline job #70999

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI Reporter for saved objects field count#70580

CI Reporter for saved objects field count#70580
rudolf merged 13 commits intoelastic:masterfrom
rudolf:so-field-count-ci-reporter

rudolf commented Jul 2, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jul 3, 2020

Uh oh!

spalger commented Jul 3, 2020

Uh oh!

Uh oh!

spalger commented Jul 4, 2020

Uh oh!

rudolf commented Jul 6, 2020

Uh oh!

Uh oh!

spalger Jul 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rudolf commented Jul 7, 2020

Uh oh!

kibanamachine commented Jul 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rudolf commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 3, 2020

Uh oh!

spalger commented Jul 3, 2020

Uh oh!

Uh oh!

spalger commented Jul 4, 2020

Uh oh!

rudolf commented Jul 6, 2020

Uh oh!

Uh oh!

spalger Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rudolf commented Jul 7, 2020

Uh oh!

kibanamachine commented Jul 7, 2020

💚 Build Succeeded

Build metrics

Saved Objects .kibana field count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rudolf commented Jul 2, 2020 •

edited

Loading