Skip to content

Passed buffer as 0 to fix extra gap in EuiSuperSelect#3685

Merged
elizabetdev merged 4 commits intoelastic:masterfrom
shrey:shrey21
Jul 2, 2020
Merged

Passed buffer as 0 to fix extra gap in EuiSuperSelect#3685
elizabetdev merged 4 commits intoelastic:masterfrom
shrey:shrey21

Conversation

@shrey
Copy link
Copy Markdown
Contributor

@shrey shrey commented Jul 1, 2020 •
edited by elizabetdev
Loading

Summary

Sent buffer as 0 in the EuiSuperSelect component to avoid extra spacing.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu Some ts related error is occurring, maybe y'all can take a look into it.
Screenshot 2020-07-02 at 4 21 11 AM

Closes #3565

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 1, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@shrey shrey changed the title Passed buffer as 0 to fix extra gap in superselect Passed buffer as 0 to fix extra gap in EuiSuperSelect Jul 1, 2020
@anishagg17
Copy link
Copy Markdown
Contributor

anishagg17 commented Jul 1, 2020

Some ts related error is occurring,

Is your fork up-to-date with master branch?

@shrey
Copy link
Copy Markdown
Contributor Author

shrey commented Jul 1, 2020

Some ts related error is occurring,

Is your fork up-to-date with master branch?
Yeah, I rebased with the upstream and pushed it

@elizabetdev
Copy link
Copy Markdown
Contributor

elizabetdev commented Jul 2, 2020

Jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3685/

@elizabetdev
Copy link
Copy Markdown
Contributor

elizabetdev commented Jul 2, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3685/

@elizabetdev
Copy link
Copy Markdown
Contributor

elizabetdev commented Jul 2, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3685/

@elizabetdev elizabetdev self-requested a review July 2, 2020 12:17
elizabetdev
elizabetdev approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shrey! Tested locally and it looks good. 🎉

@elizabetdev elizabetdev merged commit 62b5d94 into elastic:master Jul 2, 2020
@thompsongl thompsongl mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elizabetdev elizabetdev elizabetdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EuiSuperSelect] Dropdown not rendering properly

4 participants

@shrey @kibanamachine @anishagg17 @elizabetdev