Compute EuiComboBox's listbox zIndex#3551
Merged
chandlerprall merged 5 commits intoelastic:masterfrom Jun 10, 2020
Merged
Conversation
cchaos
suggested changes
Jun 4, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/ |
cchaos
approved these changes
Jun 10, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Thanks! LGTM. I can think of any degradations at the moment, so 🤞
snide
approved these changes
Jun 10, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Tested in browser and can't think of any problems this could cause.
Contributor
Author
|
jenkins test this? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/ |
phyolim
pushed a commit
to phyolim/eui
that referenced
this pull request
Jun 11, 2020
* Updated EuiComboBox to match its combobox zIndex when rendering the listbox * changelog * Removed , now programmatically determining combobox options list zindex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue reported by @Kerry350 where a flyout>expression>popover>combobox's options list is rendered under the popover.
getElementZIndexfrom popover_positioning service to find the target zIndex when opening the listboxBefore
After
Checklist
- [ ] Check against all themes for compatibility in both light and dark modesIE11and Firefox- [ ] Props have proper autodocs