Skip to content

[Console] Fix a11y keyboard overlay#71214

Merged
jloleysens merged 6 commits intoelastic:masterfrom
jloleysens:console/fix-a11y-overlay
Jul 10, 2020
Merged

[Console] Fix a11y keyboard overlay#71214
jloleysens merged 6 commits intoelastic:masterfrom
jloleysens:console/fix-a11y-overlay

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens commented Jul 9, 2020

Summary

Fix #71157

It looks like at some point the .kbnUiAceKeyboardHint class was no longer globally available. This created an issue where the a11y overlay would be there but would be very small/invisible. The fix implemented here is to copy over the legacy styles and have them live with the hook that is currently responsible for rendering the overlay.

Also refactored the hook to live in ace folder following the pattern of __packages_do_no_import__.

This will have affected Search Profiler too.

How to test

See #71157 for steps to test.

Gif

overlay

Checklist

@jloleysens
Fix a11y keyboard overlay
0aa698c 
- reinclude styling for the keyboard overlay (copied from legacy)
- refactor the exports of es_ui_shared to follow new pattern
@jloleysens jloleysens added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler v7.9.0 v7.8.2 labels Jul 9, 2020
@jloleysens jloleysens requested a review from cjcenizal July 9, 2020 09:46
@jloleysens jloleysens requested a review from a team as a code owner July 9, 2020 09:46
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 9, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jul 9, 2020

@elasticmachine merge upstream

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jul 9, 2020

@elasticmachine merge upstream

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jul 9, 2020

@elasticmachine merge upstream

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jul 9, 2020

@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM! Behavior is on-par with that of 7.7.

@cjcenizal
Copy link
Copy Markdown
Contributor

cjcenizal commented Jul 9, 2020

I also verified that this behavior was working as expected in 7.8. So the bug was introduced during 7.9 dev and we only need to backport to 7.x.

@jloleysens jloleysens removed the v7.8.2 label Jul 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console/fix-a…
b605b6b 
…11y-overlay

* 'master' of github.com:elastic/kibana: (33 commits)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI
  Deduplication of entries and items before sending to endpoint (elastic#71297)
  [services/remote/webdriver] fix eslint error (elastic#71346)
  send slack notifications on visual baseline failures
  fix visual regression job (elastic#70999)
  [Ingest Manager] Add schema to usageCollector. (elastic#71219)
  [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279)
  [Ingest Manager] Fix limited packages incorrect response (elastic#71292)
  Support multiple features declaring same properties (elastic#71106)
  [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183)
  [DOCS] Clarify trial subscription levels (elastic#70636)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 10, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
esUiShared 117 +13 104

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 12ec1be into elastic:master Jul 10, 2020
@jloleysens jloleysens deleted the console/fix-a11y-overlay branch July 10, 2020 10:40
@jloleysens jloleysens mentioned this pull request Jul 10, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 10, 2020
@jloleysens @elasticmachine
Fix a11y keyboard overlay (elastic#71214)
63a6d66 
- reinclude styling for the keyboard overlay (copied from legacy)
- refactor the exports of es_ui_shared to follow new pattern

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Jul 10, 2020
@jloleysens @elasticmachine
Fix a11y keyboard overlay (#71214) (#71367)
8be9792 
- reinclude styling for the keyboard overlay (copied from legacy)
- refactor the exports of es_ui_shared to follow new pattern

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 13, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
048e769 
* master: (78 commits)
  Bump lodash package version (elastic#71392)
  refactor: 💡 use allow-list in AppArch codebase (elastic#71400)
  improve bugfix 7198 test stability (elastic#71250)
  [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198)
  [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172)
  [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269)
  [Security Solution] Allow to configure Event Renderers settings (elastic#69693)
  Fix a11y keyboard overlay (elastic#71214)
  [APM] UI text updates (elastic#71333)
  [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113)
  [SIEM] fix tooltip of notes (elastic#71342)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cjcenizal cjcenizal cjcenizal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Console Dev Tools Console Feature Feature:Search Profiler release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Console is keyboard-inaccessible

4 participants

@jloleysens @elasticmachine @cjcenizal @kibanamachine