Added display prop to EuiDataGridColumnSortingDraggable#3574
Merged
chandlerprall merged 4 commits intoelastic:masterfrom Jun 8, 2020
Merged
Added display prop to EuiDataGridColumnSortingDraggable#3574chandlerprall merged 4 commits intoelastic:masterfrom
chandlerprall merged 4 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
Contributor
|
jenkins test this |
chandlerprall
suggested changes
Jun 8, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
Contributor
|
jenkins test this |
chandlerprall
approved these changes
Jun 8, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; Tested in the PR's deploy. Will merge when CI passes
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From: #3520 (comment)
Added display prop to
EuiDataGridColumnSortingDraggableto set the value to the column sorting popover popoverChecklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests