Skip to content

chore(release): 4.5.0#3729

Merged
WilcoFiers merged 148 commits intomasterfrom
release-4.5.0
Oct 24, 2022
Merged

chore(release): 4.5.0#3729
WilcoFiers merged 148 commits intomasterfrom
release-4.5.0

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Oct 17, 2022

No description provided.

WilcoFiers and others added 30 commits February 4, 2022 16:37
chore: merge master into develop
Parcel.io (https://parcel.io) now integrates axe-core. Change `/docs/projects.md` to include Parcel
* ci: fix nightly chrome

* fix package-lock

* fix

* npx

* test nightly

* verbose

* fix chrome install

* almost there

* fix config

* Update package.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* chore: resolve npm audit issues

* fix ACT karma config

* chore(runPartial): skip tests in IE

* ci: try upgrading win executor

* Update config.yml

* Update config.yml

* More tests not running in IE

* More of these

* bump karma version

* avoid using .finally()
* chore: generate metadata-function-map

* cleanup

* fix windows

* ignore file
…s as disabled (#3393)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem

* fix(commons/dom): focusDisabled() behavior

Now checks "disabled" attribute

Closes issue #3315

* Update lib/commons/dom/focus-disabled.js

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* fix typo

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* tests: split out respondable and frame-messenger tests

* remove
…les, add role to message (#3395)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem

* fix(rules): unsupportedrole check bugs

Closes issue #3282

* lint fix

* add assertion on checkContext._data to unit tests

* refactor(checks/unsupportedrole): change this.data from using array to single string

to match lib/checks/aria/deprecatedrole-evaluate.js

* Revert "refactor(checks/unsupportedrole): change this.data from using array to single string"

This reverts commit e7c757f9330b635b1ed16385b3526f2e71786488.

* refactor(checks/unsupportedrole): change this.data from using array to single string
…eprecated role, improve color-contrast pass messages (#3387)

* fix(deprecatedrole): fix message to properly include deprecated role

* add tests

* ie11
* chore(i18n): update Japanese translation

grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*

* Update locales/ja.json

role -> ロール

Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>

* Update locales/ja.json

role -> ロール

Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>

* Update locales/ja.json

陰 -> 影

Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>

* Update locales/ja.json

陰 -> 影

Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>

* Add ja translation for checks/no-focusable-content

* Make checks/aria-valid-attr-value/incomplete/noId consistent with ./idrefs

* Remove unnecessary whitespaces from checks/aria-valid-attr-value/incomplete/{noId,idrefs}

Co-authored-by: Kiyochika Nakamura <kiyochika@gmail.com>
* update role allowances for nav element

closes #3401

allows `none` and `presentation` role on `<nav>` element.

* tests for nav role allowance update

* add entries for nav role allowance updates

* Update lib/standards/html-elms.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* ci(act): Add nightly job to run latest ACT rules

* Update .circleci/config.yml

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* Update `help` value to include focusable elements

The current `help` value does not include the scenario in which `aria-hidden="true"` is on a focusable element. I updated it to include that scenario. Here's the PR, per Wilco's suggestion. Slack thread: https://deque.slack.com/archives/C0LA5E545/p1646762357136919

* Update lib/rules/aria-hidden-focus.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* feat(locale): added Norwegian Bokmål locale (nb-no)

* fix(locale): rename locale file to nb_NO and make corrections

* fix(locale): Correct some translations, changed 'bør' to 'skal'

Bør feels more like a recommendation; optional. 'Skal' makes it clear

* fix(locale): locale corrections for no_NB

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update locales/no_NB.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* fix(locale): change of grammar

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* ci: fix nightly build

* try again

* run

* fix it?

* revert workflow
…d of incompletes (#3427)

* Update empty-table-header.json

References #3404

* update tests

* ignore aira-practices pages that violate empty-table-header

* remove impact from rule

Co-authored-by: Steven Lambert <steven.lambert@deque.com>
…erent shadow DOM tree (#3421)

* fix(aria-valid-attr-value): add note about element id being in a different shadow DOM tree

* only mention shadow tree if one exists

* fix test
* ensure pseudo elements also return required contrast information

* Update test/checks/color/color-contrast.js

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* remove rule description changes

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
chore: merge master into develop
* feat(getRules): return actIds when set

* Update doc/API.md
WilcoFiers and others added 20 commits October 4, 2022 22:33
* fix(object-alt): ignore unloaded objects

* fix failing test
…3676)

* fix(is-visible-on-screen): ignore elements hidden by overflow:hidden

* finalize

* suggestions

* suggestions

* revert files from prettier not in scope

* move test
* feat(link-in-text-block): Enable rule by default

* update rule-descriptions

* Fix integration test

* Skip APG issue
* chore(target-size): Avoid testing nested widgets

* Include descendants in the tab order

* Exclude nested widgets with tabindex="-1"

* improve tests
* chore: update deps

* major versions

* fix

* update selenium-webdriver
* chore(target-size): Avoid testing nested widgets

* Include descendants in the tab order

* Exclude nested widgets with tabindex="-1"

* improve tests

* chore(target-size): report non-tabbable widgets for review

* Handle integration test

* Update based on feedback
…ately (#3715)

* chore(target-size): Avoid testing nested widgets

* Include descendants in the tab order

* Exclude nested widgets with tabindex="-1"

* improve tests

* chore(target-size): report non-tabbable widgets for review

* Handle integration test

* Update based on feedback

* chore(target-size): consider fixed and non-fixed position nodes separately
… and color-contrast-enhanced (#3714)

* fix(color-contrast-enhanced): only report violations for contrasts that pass color-contrast

* report incomplete

* Update lib/checks/color/color-contrast-evaluate.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* changes

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* chore: update playground

* no async
* fix(list/definition-list): Clarify remediation messages

* Add docs

* Tweaks

* Remove log
…ontent (#3722)

* chore(target-size): return incomplete when targets have overflowing content

* tweaks
…hidden (#3726)

* fix(is-hidden-for-everyone): count element inside closed details as hidden

* fix for not first summary node

* minor fixes; add color contrast check
@straker straker requested a review from a team as a code owner October 17, 2022 17:23
@straker
Copy link
Copy Markdown
Contributor Author

straker commented Oct 20, 2022

Reviewed ac361ca, a6a5a6a, and 7ab61c2 for security

Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilcoFiers WilcoFiers merged commit d27488e into master Oct 24, 2022
@WilcoFiers WilcoFiers deleted the release-4.5.0 branch October 24, 2022 15:53
@dylanb
Copy link
Copy Markdown
Contributor

dylanb commented Oct 27, 2022

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.