Merged
Conversation
WilcoFiers
approved these changes
Apr 11, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
* ci: fix nightly build * try again * run * fix it? * revert workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently what was going on was that after
npx browser-driver-manager install chromedriverinstalled chromedriver 99/100, doingnpm install w3c/aria-practices#mainwould override the previously installed chromedriver with the version listed inpackage-lock.json. So the fix was to change the order of installs so that chromedriver was installed as the last thing.Also fixed the nightly act running apg instead.
Here's the build showing nightly works now https://app.circleci.com/pipelines/github/dequelabs/axe-core/3537/workflows/1685f851-de20-40d5-b955-bf36ab194c51