ci(act): Add nightly job to run latest ACT rules#3403
Merged
WilcoFiers merged 2 commits intodevelopfrom Mar 7, 2022
Merged
Conversation
straker
previously requested changes
Mar 4, 2022
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Mar 7, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
* ci(act): Add nightly job to run latest ACT rules * Update .circleci/config.yml Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the ACT job fail because of an update to one of the rules. This PR makes it so we run tests against a pinned version of ACT. We'll have a nightly job run against the latest ACT rules so we can see if something in ACT broke our implementation.
I haven't looked at what was failing specifically. I'll do that in a separate PR.