Skip to content

feat(empty-table-headers): rule is now best-practice and fails instead of incompletes#3427

Merged
straker merged 4 commits intodequelabs:developfrom
fstrr:patch-1
Apr 12, 2022
Merged

feat(empty-table-headers): rule is now best-practice and fails instead of incompletes#3427
straker merged 4 commits intodequelabs:developfrom
fstrr:patch-1

Conversation

@fstrr
Copy link
Copy Markdown
Contributor

@fstrr fstrr commented Mar 29, 2022

References #3404

Updated empty table headers rule to be best practice rather than a WCAG failure.

Closes issue:

@fstrr fstrr requested a review from a team as a code owner March 29, 2022 17:00
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 29, 2022

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Copy Markdown
Contributor

straker commented Mar 29, 2022

Thanks for the pr. The tests are failing because reviewOnFailed was removed, which is causing the integration tests to fail (it was looking for incomplete before).

The way the integration tests work is they use a json file, which is paired with an html file. The json file lists the expected output of html elements in the html file (listed by the element ids). In this case, we expect there to be 3 incomplete results.

To fix the tests, we'll just need to update the json file to use violations instead of incomplete and update the id names for each of the elements (we typically use pass, fail, and incomplete for the id names). Something like the following:

{
  "description": "empty-table-header tests",
  "rule": "empty-table-header",
  "violations": [["#fail1"], ["#fail2"], ["#fail3"]],
  "passes": [["#pass1"], ["#pass2"], ["#pass3"]]
}

fstrr added a commit to fstrr/axe-core that referenced this pull request Mar 29, 2022
References: dequelabs#3427#issuecomment-1082395595

Hopefully this does the trick
@straker straker changed the title Update empty-table-header.json fix(empty-table-headers): rule is now best-practice and fails instead of incompletes Apr 1, 2022
@WilcoFiers WilcoFiers changed the title fix(empty-table-headers): rule is now best-practice and fails instead of incompletes feat(empty-table-headers): rule is now best-practice and fails instead of incompletes Apr 12, 2022
@WilcoFiers
Copy link
Copy Markdown
Contributor

Reviewed for security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants