feat(empty-table-headers): rule is now best-practice and fails instead of incompletes#3427
Merged
straker merged 4 commits intodequelabs:developfrom Apr 12, 2022
Merged
feat(empty-table-headers): rule is now best-practice and fails instead of incompletes#3427straker merged 4 commits intodequelabs:developfrom
straker merged 4 commits intodequelabs:developfrom
Conversation
References dequelabs#3404
Contributor
|
Thanks for the pr. The tests are failing because The way the integration tests work is they use a json file, which is paired with an html file. The json file lists the expected output of html elements in the html file (listed by the element ids). In this case, we expect there to be 3 incomplete results. To fix the tests, we'll just need to update the json file to use {
"description": "empty-table-header tests",
"rule": "empty-table-header",
"violations": [["#fail1"], ["#fail2"], ["#fail3"]],
"passes": [["#pass1"], ["#pass2"], ["#pass3"]]
} |
fstrr
added a commit
to fstrr/axe-core
that referenced
this pull request
Mar 29, 2022
References: dequelabs#3427#issuecomment-1082395595 Hopefully this does the trick
WilcoFiers
approved these changes
Apr 12, 2022
Contributor
|
Reviewed for security |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #3404
Updated empty table headers rule to be best practice rather than a WCAG failure.
Closes issue: