feat(presentation-role-conflict): Test img elements with empty alt#3717
Merged
WilcoFiers merged 2 commits intodevelopfrom Oct 12, 2022
Merged
feat(presentation-role-conflict): Test img elements with empty alt#3717WilcoFiers merged 2 commits intodevelopfrom
WilcoFiers merged 2 commits intodevelopfrom
Conversation
straker
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imgelements with an empty alt attribute should not be focusable, or have global ARIA attributes. I was previously reluctant to fail for example<img alt="" aria-label="hello">, but it seems that browsers are not consistent about how to deal with this. There's an ARIA issue open on this topic here: w3c/aria#1824 (comment)This also solves a consistency issue with ACT, which is nice. I was previously advocating to have that ACT rule updated, but now that there's a clear problem caught here, I think axe-core should fail this.
Closes issue: #3702