Merged
Conversation
d7fd5df to
214c318
Compare
214c318 to
39b2c62
Compare
bf72798 to
f5f7679
Compare
8404433 to
1e73241
Compare
straker
approved these changes
Feb 11, 2022
straker
pushed a commit
that referenced
this pull request
May 12, 2022
* chore: resolve npm audit issues * fix ACT karma config * chore(runPartial): skip tests in IE * ci: try upgrading win executor * Update config.yml * Update config.yml * More tests not running in IE * More of these * bump karma version * avoid using .finally()
ljharb
reviewed
Jul 11, 2022
| "license": "MPL-2.0", | ||
| "engines": { | ||
| "node": ">=4" | ||
| "node": ">=12" |
Contributor
There was a problem hiding this comment.
note: this is a breaking change and requires a semver-major update. See #3537.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issues reported by
npm audit. This required replacing karma-mocha-reporter with karma-spec-reporter. Since karma-mocha-report hasn't been published for 4 years I thought it'd best to just replace it. We'll have a slightly different test report as a result, but it's minor.Also bumping node version to >=12. There is no way axe-core tests can run on Node v4. Mocha v9 only runs on Node v12+.