fix(html-elms): update role allowances for nav element#3402
Merged
WilcoFiers merged 4 commits intodequelabs:developfrom Mar 7, 2022
Merged
fix(html-elms): update role allowances for nav element#3402WilcoFiers merged 4 commits intodequelabs:developfrom
WilcoFiers merged 4 commits intodequelabs:developfrom
Conversation
closes dequelabs#3401 allows `none` and `presentation` role on `<nav>` element.
WilcoFiers
requested changes
Mar 7, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Spacing thing, and then would you mind adding a test case to test/integration/rules/aria-allowed-role/aria-allowed-role.html, so that we can prevent regression.
Also, as a question, how come <main> isn't allowed role=none, but footer, header, aside and now nav are?
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Contributor
Author
|
@WilcoFiers added the tests (and also added the tests to my other PR. somehow missed your ask on that). re: |
WilcoFiers
approved these changes
Mar 7, 2022
Contributor
|
Reviewed for security. I'm going to merge this despite the failing tests. Those are unrelated to this PR. A fix for that is merging into develop today too. |
straker
pushed a commit
that referenced
this pull request
May 12, 2022
* update role allowances for nav element closes #3401 allows `none` and `presentation` role on `<nav>` element. * tests for nav role allowance update * add entries for nav role allowance updates * Update lib/standards/html-elms.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3401
allows
noneandpresentationrole on<nav>element.