Conversation
WilcoFiers
previously requested changes
Feb 8, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
I was thinking about this the other day. We don't really have a way to test this, which has caused a few issues. How about if we add something to testUtils.MockCheckContext that lets us write tests for these messages?
Contributor
Author
|
Doing this revealed that color-contrast had a few pass cases where the message wasn't passed any data. Fixed those with the test. |
WilcoFiers
previously requested changes
Feb 24, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM, just update the title, since you're not just touching deprecatedrole.
WilcoFiers
approved these changes
Feb 28, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
…eprecated role, improve color-contrast pass messages (#3387) * fix(deprecatedrole): fix message to properly include deprecated role * add tests * ie11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed during review (my fault) that
data.valueswouldn't work for non-arraydatastring. Might try my hand at extending our check message validation script to include verifying that the data object matches all interpolated parts of the string (probably using process-message)Closes issue: #3384