chore(target-size): consider fixed and non-fixed position nodes separately#3715
Merged
WilcoFiers merged 10 commits intodevelopfrom Oct 13, 2022
Merged
chore(target-size): consider fixed and non-fixed position nodes separately#3715WilcoFiers merged 10 commits intodevelopfrom
WilcoFiers merged 10 commits intodevelopfrom
Conversation
straker
approved these changes
Oct 12, 2022
Contributor
|
Just adding a note since this is a different pr. We decided to not account for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have the target-size rule test fixed position elements separate from those not that are not fixed.
Closes issue: #3672