Skip to content

fix(aria-valid-attr-value): add note about element id being in a different shadow DOM tree#3421

Merged
straker merged 4 commits intodevelopfrom
aria-valid-attr-value-shadow-id
Apr 12, 2022
Merged

fix(aria-valid-attr-value): add note about element id being in a different shadow DOM tree#3421
straker merged 4 commits intodevelopfrom
aria-valid-attr-value-shadow-id

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Mar 22, 2022

Closes issue: #3419

@straker straker requested a review from a team as a code owner March 22, 2022 15:36
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

* the spec for this)
*/

let hasShadowRoot;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little hackish... but alright.

@straker straker merged commit 5a4babb into develop Apr 12, 2022
@straker straker deleted the aria-valid-attr-value-shadow-id branch April 12, 2022 14:43
straker added a commit that referenced this pull request May 12, 2022
…erent shadow DOM tree (#3421)

* fix(aria-valid-attr-value): add note about element id being in a different shadow DOM tree

* only mention shadow tree if one exists

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants