feat(locale): Added Norwegian Bokmål locale#3375
Merged
WilcoFiers merged 22 commits intodequelabs:developfrom Mar 29, 2022
Merged
feat(locale): Added Norwegian Bokmål locale#3375WilcoFiers merged 22 commits intodequelabs:developfrom
WilcoFiers merged 22 commits intodequelabs:developfrom
Conversation
|
|
WilcoFiers
reviewed
Feb 4, 2022
DagA11y
suggested changes
Feb 24, 2022
DagA11y
left a comment
There was a problem hiding this comment.
Finally went through all items and made my suggestions.
It seems that some plurals and singulars were mixed, maybe also an issue in the Danish translations...
Bør feels more like a recommendation; optional. 'Skal' makes it clear
Contributor
Author
|
Yep I noticed, did a few additional iterations. Should be good to merge now IMO :-) |
WilcoFiers
requested changes
Feb 28, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Feedback provided by Mikael Snaprud. Please consider.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Contributor
Author
|
@WilcoFiers great suggestions! All accepted, except one. Can you please review #3375 (comment) |
WilcoFiers
approved these changes
Mar 29, 2022
Contributor
|
I reviewed this PR for security. I'm merging despite the failing test because a fix for it is already in the develop branch. @olemarius @DagA11y Thank you so much for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the danish locale (de.json) and translated to Norwegian (the languages are very similar).
The added locale is the for the main dialect in Norway. The other one, Nynorsk, is often used on websites with high focus on accessibility, so it's a good idea to keep the file naming as proposed rather than just no.json.