ci(act): rewrite URLs to properly load test assets#3681
Merged
WilcoFiers merged 3 commits intodevelopfrom Oct 12, 2022
Merged
Conversation
straker
previously approved these changes
Oct 12, 2022
straker
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was struggling in #3680 to get the ACT tests running. Now that object-alt cares about whether or not the object is loaded, I need to make sure the URLs in the test cases can actually be used to load things from, so something that starts with
/WAI/...should load from./node_modules/wcag-act-rules/. That didn't seem possible with http-server, so I pulled in a new package to ensure all test assets can be loaded.For the object-alt ACT tests to pass, PR 3680 needs to be merged first.