tests: split out respondable and frame-messenger tests#3396
Merged
Conversation
WilcoFiers
approved these changes
Feb 24, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
* tests: split out respondable and frame-messenger tests * remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping this "fixes" the flakey respondable tests by removing the timeout of 1 second.
I've split out respondable across 3 files to see if the test still fail, and if so if it fails consistently in the same file. I'm hoping that reducing the amount of times the iframe has to be removed and replaced into the dom in the same suite removes whatever error the
beforeEachwas giving. If not, I've also tried to add error handling to thebeforeEachiframe injection hoping it shows us a usable error other than a timeout.I have run the tests about 8 times now and haven't had it fail on respondable tests.
Closes issue: #2849
Closes issue: #2860
Closes issue: #2867