tests: resolve isolated-env race condition#3398
Merged
Conversation
WilcoFiers
approved these changes
Mar 1, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM; I did change your PR title though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there was a race condition in the isolated-env tests between when the iframe
loadevent was triggered and when the script contents to fetch axe and inject it into the page viaevalwould complete. Tests would fail if the script couldn't execute faster than theloadevent.Fixed that by properly waiting for the post message the script sends in addition to waiting for the nested load function.
Closes issue: #3367