Add automated accessibility audit + HTML validation to CI pipeline#7751
Merged
mrcasals merged 4 commits intodecidim:developfrom Mar 27, 2021
Merged
Add automated accessibility audit + HTML validation to CI pipeline#7751mrcasals merged 4 commits intodecidim:developfrom
mrcasals merged 4 commits intodecidim:developfrom
Conversation
- Homepage signed in and signed out - Account main page - Conversations pages - Static pages with and without topics + index - Pages component - Participatory processes listing page - Participatory process steps/phases page - Proposals listing page + single proposal page
Contributor
|
@ahukkanen all PRs merged, thank you SO MUCH for these PRs! ❤️ |
Contributor
Author
|
@mrcasals Tests are passing, this is now ready. |
mrcasals
approved these changes
Mar 27, 2021
entantoencuanto
added a commit
that referenced
this pull request
Mar 31, 2021
* develop: (26 commits) Fix trustees admin menu (#7772) Do not modify the controller class in the controller tests that render views (#7755) Add HTML escaping to the expectations as the strings are escaped (#7760) Add automated accessibility audit + HTML validation to CI pipeline (#7751) fix(elections): js assets manifest (#7759) Add admin missing translations (#7702) Add Conferences and Admin missing translations (#7653) New Crowdin updates (#7735) Improve vote flow (#7682) Strip the <p> tags from inside the heading elements (#7732) Fix the date cell spec failing randomly close to day changes (#7703) Change the timeline date color for accessible color contrast against its background (#7750) Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749) Fix color contrast against the sidebar navigation background (#7748) Validate the HTML for the account page (#7747) Fix report modal form accessibility (#7746) Accessibility fixes for conversations (#7745) Add a landmark ARIA role to the cookie banner (#7738) Fix HTML validation on standalone content page (#7744) Add aria-label to the area filter on participatory space pages (#7743) ...
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We've had many accessibility issues with Decidim and I would expect new accessibility issues to come up from time to time. There is also quite a long way still to make Decidim 100% accessible.
This is the first step to that direction. This adds automated accessibility audit using
axe-coreto the CI pipeline and also W3C HTML validation using thew3c_validatorsgem.This alone will not make Decidim 100% accessible some day but it makes sure new changes won't break any accessibility features that have been already fixed. And if design is changed, it will make it easier to keep the new design accessible.
This adds two new dependencies to the
decidim-devmodule:axe-core-rspecwhich is an rspec wrapper foraxe-core- Both licensed with MPL 2.0w3c_rspec_validatorswhich is an rspec wrapper forw3c_validators- Both licensed with MITThis also adds new shared examples with the name
accessible pagewhich can be applied to any page. This will run both validations for the given page:This should be gradually applied to all pages that we want to be accessible. The goal of this PR is to introduce the concept to the core, not to implement it everywhere (due to the heavy amount of work needed to make everything accessible). This PR adds it to the following pages:
As these validations are added to these pages, we first need to make sure all tested pages are valid. Therefore, this depends on the following PRs to be merged first:
ariaprefix) #7707<nav>menus #7709<p>tags from inside the heading elements #7732📌 Related Issues
Testing
Run the specs and see the results.
📋 Checklist
docs/.