Closed
Conversation
Original commit: 1544e10
Original commit: 5a81430
Original commit: 6465e60
Original commit: 1229b68
Original commit: e8e84d1
Original commit: ce04745
…ialog Original commit: 94ed843
Original commit: 56510c9
Original commit: 11f19ed
Original commit: 17a0ed0
- Fix the expected titles and button texts after the ALLCAPS change [TAC042] - Fix expected error states when passing too short texts and texts with too many uppercase characters [TAC061] Original commit: bd53650
Original commit: 2e2797e
Original commit: 965c462
Original commit: 5061c32
Original commit: d418736
- Promote to proposal button for amendments - Collaborative drafts edit and request access buttons Original commit: 3ae8d9d
Original commit: a1f32fd
Original commit: c7415d0
Original commit: c612463
Original commit: 53d5adf
Original commit: 7c6924b
Original commit: 01f2609
6 tasks
Contributor
Contributor
|
Closing as it has been superseded by #6253 |
This was referenced Mar 21, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The great work that got started by MoretS continues.
This pull request is a big one but fixes many accessibility issues in Decidim. More information about the fixed issues is available from:
https://trello.com/b/gu7Ztm3C/decidim-accessibility
These issues have been reported by accessibility experts for two cities in Finland.
There are still some issues remaining after this but this addresses all the "extremely important" and "important" level issues, which should be enough to pass most accessibility reviews.
A thing to note is also that the accessibility reviews have been done on customized Decidim themes, so the color contrasts of the default theme have not been reviewed by any experts. That is left for further evaluation.
📌 Related Issues
📋 Subtasks
CHANGELOGentry