Conversation
oriolgual
approved these changes
Mar 30, 2021
orlera
approved these changes
Mar 30, 2021
agustibr
approved these changes
Mar 30, 2021
Contributor
Author
|
@decidim/mantainers this is ready to be merged! |
entantoencuanto
added a commit
that referenced
this pull request
Mar 31, 2021
* develop: (26 commits) Fix trustees admin menu (#7772) Do not modify the controller class in the controller tests that render views (#7755) Add HTML escaping to the expectations as the strings are escaped (#7760) Add automated accessibility audit + HTML validation to CI pipeline (#7751) fix(elections): js assets manifest (#7759) Add admin missing translations (#7702) Add Conferences and Admin missing translations (#7653) New Crowdin updates (#7735) Improve vote flow (#7682) Strip the <p> tags from inside the heading elements (#7732) Fix the date cell spec failing randomly close to day changes (#7703) Change the timeline date color for accessible color contrast against its background (#7750) Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749) Fix color contrast against the sidebar navigation background (#7748) Validate the HTML for the account page (#7747) Fix report modal form accessibility (#7746) Accessibility fixes for conversations (#7745) Add a landmark ARIA role to the cookie banner (#7738) Fix HTML validation on standalone content page (#7744) Add aria-label to the area filter on participatory space pages (#7743) ...
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The Trustees menu in the admin zone of participatory spaces should be shown on all participatory spaces with an Elections component, but it was only included on the Participatory Processes spaces.
This PR fixes this problem, normalizing first the names of these menus with the format
:admin_[participatory_space]_menu(e.g.:admin_voting_menu,:admin_assembly_menu, etc.) and then adding the menu element to that menu of each registered participatory space. Some tests to check this on assemblies and votings are also added (I didn't add for other spaces because they are not loaded during elections tests).In the future, we could improve this PR creating a new menu with the common items for all participatory spaces and rendering it after the specific space menu, but that would need to refactor all menu presenter classes, as they only support rendering one menu.
This PR also fixes a silly issue with a missing translation on the assemblies submenu.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
