Add admin missing translations#7702
Merged
mrcasals merged 6 commits intodecidim:developfrom Mar 26, 2021
Merged
Conversation
Contributor
|
@tramuntanal it seems tests are failing, could you review them please? 😄 |
mrcasals
approved these changes
Mar 26, 2021
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Mar 29, 2021
12 tasks
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Mar 29, 2021
12 tasks
entantoencuanto
added a commit
that referenced
this pull request
Mar 31, 2021
* develop: (26 commits) Fix trustees admin menu (#7772) Do not modify the controller class in the controller tests that render views (#7755) Add HTML escaping to the expectations as the strings are escaped (#7760) Add automated accessibility audit + HTML validation to CI pipeline (#7751) fix(elections): js assets manifest (#7759) Add admin missing translations (#7702) Add Conferences and Admin missing translations (#7653) New Crowdin updates (#7735) Improve vote flow (#7682) Strip the <p> tags from inside the heading elements (#7732) Fix the date cell spec failing randomly close to day changes (#7703) Change the timeline date color for accessible color contrast against its background (#7750) Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749) Fix color contrast against the sidebar navigation background (#7748) Validate the HTML for the account page (#7747) Fix report modal form accessibility (#7746) Accessibility fixes for conversations (#7745) Add a landmark ARIA role to the cookie banner (#7738) Fix HTML validation on standalone content page (#7744) Add aria-label to the area filter on participatory space pages (#7743) ...
oriolgual
pushed a commit
that referenced
this pull request
Apr 5, 2021
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Apr 14, 2021
…in_missing_js_translation Add admin missing translations (decidim#7702)
laurajaime
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In the admin panel there is a message that is not translated.
When editing an official Proposal the title length validator message always appears in English because translations are not loaded into JavaScript.
This PR also changes the case of the first letter of the
form.length_validatormessage. This is: "at least 15 characters" to "At least 15 characters". This way the message doesn't start with downcase in the first part and changes to uppercase in the second part. Second part ("150 characters left") can't be changed because it is reused fromdecidim-commentsmodule where it is used alone.While working on this PR I also found a JS error when loading the edit proposal page when the proposal has no address. This is also fixed in commit 105c5f4 .
📌 Related Issues
Link your PR to an issue
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Editing an official Proposal
Before
After
The translation will be corrected in crowdin