Skip to content

Add aria-label to the area filter on participatory space pages#7743

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/a11y-participatory-space-area-filter-label
Mar 26, 2021
Merged

Add aria-label to the area filter on participatory space pages#7743
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/a11y-participatory-space-area-filter-label

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This adds a missing aria-label to the area filter on participatory space pages.

All fields need either an associated <label> element or aria-label attribute.

📌 Related Issues

Testing

Run the processes index page through an automated accessibility check.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Mar 26, 2021
@mrcasals mrcasals merged commit ac5049e into decidim:develop Mar 26, 2021
@ahukkanen ahukkanen deleted the fix/a11y-participatory-space-area-filter-label branch March 26, 2021 13:23
entantoencuanto added a commit that referenced this pull request Mar 31, 2021
* develop: (26 commits)
  Fix trustees admin menu (#7772)
  Do not modify the controller class in the controller tests that render views (#7755)
  Add HTML escaping to the expectations as the strings are escaped (#7760)
  Add automated accessibility audit + HTML validation to CI pipeline (#7751)
  fix(elections): js assets manifest (#7759)
  Add admin missing translations (#7702)
  Add Conferences and Admin missing translations (#7653)
  New Crowdin updates (#7735)
  Improve vote flow (#7682)
  Strip the <p> tags from inside the heading elements (#7732)
  Fix the date cell spec failing randomly close to day changes (#7703)
  Change the timeline date color for accessible color contrast against its background (#7750)
  Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749)
  Fix color contrast against the sidebar navigation background (#7748)
  Validate the HTML for the account page (#7747)
  Fix report modal form accessibility (#7746)
  Accessibility fixes for conversations (#7745)
  Add a landmark ARIA role to the cookie banner (#7738)
  Fix HTML validation on standalone content page (#7744)
  Add aria-label to the area filter on participatory space pages (#7743)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants