Add Conferences and Admin missing translations#7653
Merged
mrcasals merged 14 commits intodecidim:developfrom Mar 26, 2021
Merged
Add Conferences and Admin missing translations#7653mrcasals merged 14 commits intodecidim:developfrom
mrcasals merged 14 commits intodecidim:developfrom
Conversation
Contributor
|
@tramuntanal thanks for the PR! IGnoring the initiatives failures (it's a flaky and it's being solved), the job for the main module complains about i18n keys not being normalized. Could you review that, please? |
mrcasals
suggested changes
Mar 25, 2021
decidim-admin/config/locales/ca.yml
Outdated
| body: Cos | ||
| subject: Assumpte | ||
| organization: | ||
| admin_terms_of_use_body: Body for the admin terms of use |
Contributor
There was a problem hiding this comment.
@tramuntanal this shouldn't modify the ca.ymlfile, but theen.yml`!
Contributor
Author
There was a problem hiding this comment.
OMG! yes thanks!
Contributor
Author
|
Change applied |
mrcasals
approved these changes
Mar 26, 2021
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Mar 29, 2021
12 tasks
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Mar 29, 2021
12 tasks
entantoencuanto
added a commit
that referenced
this pull request
Mar 31, 2021
* develop: (26 commits) Fix trustees admin menu (#7772) Do not modify the controller class in the controller tests that render views (#7755) Add HTML escaping to the expectations as the strings are escaped (#7760) Add automated accessibility audit + HTML validation to CI pipeline (#7751) fix(elections): js assets manifest (#7759) Add admin missing translations (#7702) Add Conferences and Admin missing translations (#7653) New Crowdin updates (#7735) Improve vote flow (#7682) Strip the <p> tags from inside the heading elements (#7732) Fix the date cell spec failing randomly close to day changes (#7703) Change the timeline date color for accessible color contrast against its background (#7750) Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749) Fix color contrast against the sidebar navigation background (#7748) Validate the HTML for the account page (#7747) Fix report modal form accessibility (#7746) Accessibility fixes for conversations (#7745) Add a landmark ARIA role to the cookie banner (#7738) Fix HTML validation on standalone content page (#7744) Add aria-label to the area filter on participatory space pages (#7743) ...
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Apr 7, 2021
…issing_transations Add Conferences and Admin missing translations (decidim#7653)
mrcasals
pushed a commit
that referenced
this pull request
Apr 7, 2021
laurajaime
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The admin form for conferences has some untranslated fields.
This PR adds these fields to the corresponding locales file.
As a bonus, two fixes in
conferences_invites/index.html.erbandconferences_registrations/index.html.erb.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
As an admin, when I'm editing the conference information, I expect all fields to be translated to my current locale.
Some of the untranslated fields are: Objectives, Location, Start date, End date, Registrations enabled, ...
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
The admin form for Conferences with some of the fields out of translations
The admin form for Organization with admin_terms_of_use_body field out of translations
